Re: [PATCH v3 5/8] PCI/ASPM: Return enabled ASPM states from pcie_aspm_enabled() API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function `pcie_aspm_enabled()` returns a boolean literal (`false`) despite its return type being changed to `u32`.
--

--- Patch [5]: [PATCH v3 5/8] PCI/ASPM: Return enabled ASPM states from pcie_aspm_enabled() API ---
commit 075855b1906924e43de63fd5d55e7d8fedc2a01b
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

PCI/ASPM: Return enabled ASPM states from pcie_aspm_enabled() API

pcie_aspm_enabled() returns the pcie_link_state::aspm_enabled parameter which
contains the enabled states. But the API currently returns the bool type
which is used by the callers to decide if ASPM is enabled or not.

To allow the future callers to also make use of the enabled ASPM states,
this patch returns the actual type of pcie_link_state::aspm_enabled, u32.

> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 5e7e199c78d26..3ce6b93195663 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1694,15 +1694,17 @@ module_param_call(policy, pcie_aspm_set_policy, pcie_aspm_get_policy,
>  	NULL, 0644);
>  
>  /**
> - * pcie_aspm_enabled - Check if PCIe ASPM has been enabled for a device.
> + * pcie_aspm_enabled - Get the enabled PCIe ASPM states for a device.
>   * @pdev: Target device.
>   *
>   * Relies on the upstream bridge's link_state being valid.  The link_state
>   * is deallocated only when the last child of the bridge (i.e., @pdev or a
>   * sibling) is removed, and the caller should be holding a reference to
>   * @pdev, so this should be safe.
> + *
> + * Return: Enabled PCIe ASPM states. 0 if ASPM is disabled.
>   */
> -bool pcie_aspm_enabled(struct pci_dev *pdev)
> +u32 pcie_aspm_enabled(struct pci_dev *pdev)
>  {
>  	struct pcie_link_state *link = pcie_aspm_get_link(pdev);
>  

[Severity: Low]
Does this code still return a boolean literal on the error path?

Looking at pcie_aspm_enabled(), the error path still returns false:

    if (!link)
        return false;

Since the return type of pcie_aspm_enabled() was changed to u32, returning
false compiles because false evaluates to 0, but it obfuscates the integer
semantics of the function and might trigger static analysis warnings. Could
this be updated to return 0 instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-pci-aspm-fix-v3-0-6bd72451746e@kernel.org?part=5