Re: [PATCH] arm64/pcie/pmu: Add pci id for LECARC pcie pmu

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Inconsistent whitespace formatting in include/linux/pci_ids.h.
- [Low] The commit message is incomplete and contains typos that obscure its meaning.
--

--- Patch [1]: [PATCH] arm64/pcie/pmu: Add pci id for LECARC pcie pmu ---
commit c0d34696455e22a889eb602a30aeaa12283c0cfb
Author: Brett Zhou <brett_zhou@lecomputing.com>

arm64/pcie/pmu: Add pci id for LECARC pcie pmu

This commit adds a new PCI vendor ID for LECARC and registers it in the
DWC PCIe VSEC IDs table to support the LECARC PCIe Performance Monitoring
Unit.

> This patch adds  for LECARC SoCs that pcie Controller
> IP PCI Express DM Controller pum function

[Severity: Low]
This isn't a bug, but there appear to be a few typos and missing words in
the commit message. The phrase "adds  for" seems to be missing a word like
"support", and "pum" is likely a typo for "pmu". Could the message be
updated for clarity?

> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1c9d40e09107d..1c4fd16315054 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -173,6 +173,7 @@
>  #define PCI_VENDOR_ID_DYNALINK		0x0675
>  #define PCI_DEVICE_ID_DYNALINK_IS64PH	0x1702
>  
> +#define PCI_VENDOR_ID_LECARC            0x0720

[Severity: Low]
This isn't a bug, but does this newly added macro use spaces instead of tabs
for alignment? The rest of include/linux/pci_ids.h appears to consistently
use tabs to separate the macro name and the value.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-pcie-pmu-v1-1-1519e580313f@lecomputing.com?part=1