Re: [PATCH 2/3] alpha/PCI: Make the suffix the first __pci_dev_resource_attr() parameter

[sashiko-bot@kernel.org]

> Currently, the __pci_dev_resource_attr() helper macro takes the
> attribute name suffix as its third parameter, even though the suffix is
> what distinguishes the three attribute variants built on top of it.
> 
> Additionally, the pci_dev_resource_attr() wrapper passes an empty
> suffix, and with the suffix placed in the middle of the parameter list
> its invocation contains two consecutive commas, which checkpatch.pl
> highlights, as follows:
> 
>   ERROR: space required after that ',' (ctx:VxO)
> 
> Thus, move the suffix to the front so that the variant selector comes
> first and the empty argument follows the opening parenthesis, which
> checkpatch.pl does not complain about.  This also matches the parameter
> order used by the PCI legacy I/O and memory attribute macros introduced
> in a subsequent change.
> 
> No functional changes intended.
> 
> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721020427.1541197-1-kwilczynski@kernel.org?part=2