From: sashiko-bot@kernel.org
To: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI/sysfs: Add pci_ prefix to static PCI resource attribute names
Date: Tue, 21 Jul 2026 02:07:29 +0000 [thread overview]
Message-ID: <20260721020730.5EE1A1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260721020427.1541197-2-kwilczynski@kernel.org>
> Currently, the static binary attributes for the PCI resource files are
> generated with the names dev_resource<N>_io_attr, dev_resource<N>_uc_attr
> and dev_resource<N>_wc_attr.
>
> The macros that generate these attributes and the arrays that collect
> them already carry the pci_ prefix, as do the sibling legacy I/O and
> memory attributes, such as pci_legacy_io_attr. Only the generated
> variable names lack it.
>
> Thus, rename the generated variables to pci_dev_resource<N>_io_attr,
> pci_dev_resource<N>_uc_attr and pci_dev_resource<N>_wc_attr, and update
> the attribute pointer arrays to match.
>
> While at it, re-align the continuation backslashes in the resource
> attribute macros to match.
>
> No functional changes intended.
>
> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721020427.1541197-1-kwilczynski@kernel.org?part=1
next prev parent reply other threads:[~2026-07-21 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 2:04 [PATCH 0/3] PCI/sysfs: Follow-up to the static attribute conversion Krzysztof Wilczyński
2026-07-21 2:04 ` [PATCH 1/3] PCI/sysfs: Add pci_ prefix to static PCI resource attribute names Krzysztof Wilczyński
2026-07-21 2:07 ` sashiko-bot [this message]
2026-07-21 2:04 ` [PATCH 2/3] alpha/PCI: Make the suffix the first __pci_dev_resource_attr() parameter Krzysztof Wilczyński
2026-07-21 2:07 ` sashiko-bot
2026-07-21 2:04 ` [PATCH 3/3] PCI/sysfs: Add legacy I/O and memory attribute macros Krzysztof Wilczyński
2026-07-21 2:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721020730.5EE1A1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox