Re: [PATCH v4 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `w-disable2-gpios` property is incorrectly configured as `GPIO_ACTIVE_HIGH`, inverting the required active-low semantics for the M.2 Bluetooth RF kill signal.
--

--- Patch [2]: [PATCH v4 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector ---
commit 292c3ed97364c0f7209a33809d46b9f2b7cf145a
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector

This commit models the M.2 E key connector connected to PCIe0 on the Eliza
EVK board. It enables the PCIe0 root port, its QMP PHY, and configures the
M.2 slot's 3.3V supply rail via a TCA9538 I/O expander.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> index e47b24f8b8277..b35fffb509765 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> @@ -11,6 +11,92 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};

[ ... ]

> +	connector-0 {
> +		compatible = "pcie-m2-e-connector";
> +		vpcie3v3-supply = <&vreg_pcie_m_3p3>;
> +		w-disable1-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> +		w-disable2-gpios = <&pm8550vs_g_gpios 4 GPIO_ACTIVE_HIGH>;

[Severity: High]
Does this GPIO polarity accidentally invert the active-low semantics for the
M.2 Bluetooth RF kill signal?

The M.2 specification defines W_DISABLE2# as an active-low signal. Since
the pwrseq-pcie-m2 driver initializes this GPIO with GPIOD_OUT_HIGH (logical 1)
and enables the Bluetooth device by writing a logical 0, configuring it as
GPIO_ACTIVE_HIGH means a logical 0 translates to a physical LOW signal.

This physical LOW would then disable the radio in hardware right when the
driver intends to enable it. Should this be GPIO_ACTIVE_LOW to match the
w-disable1-gpios polarity and the specification?

> +
> +		pinctrl-0 = <&m2_w_disable1>, <&m2_w_disable2>;
> +		pinctrl-names = "default";

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-eliza_evk-v4-0-decc7fe5246e@oss.qualcomm.com?part=2