Re: [PATCH wireless v2 2/3] wifi: iwlwifi: pcie: deselect the product reset mode at probe

[sashiko-bot@kernel.org]

> The mode that iwl_trans_pcie_set_product_reset() selects lives in the
> platform's ACPI namespace, not in the device, and nothing deselects it on
> the product-reset path. iwl_trans_pcie_removal_wk() selects it, evaluates
> _RST via _PRR and removes the device; the rescan re-probes, and probe only
> reads the mode back for the log rather than clearing it, so it is still
> selected. (A later removal with a lesser mode does pass enable=false, but
> that is the path that does not need it.) It is plain namespace state - on
> the platform I have it is a named integer written by the vendor DSM and
> read back by the reset method - so it survives S3 and s2idle. Neither the
> driver nor _RST clears it.
> 
> That has a consequence. _RST branches on the mode variable, does not
> clear it, and iwl_trans_pcie_reset() takes the caller's word for which
> reset to run. So after any product reset the next escalation can do the
> wrong thing: iwl_trans_determine_restart_mode() asks for
> [ ... ]
> cleared.
> 
> Cc: stable@vger.kernel.org
> Fixes: 9673c35486d4 ("wifi: iwlwifi: implement product reset for TOP errors")
> Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831130332.323549-1-navonjohnlukose@gmail.com?part=2