Re: [PATCH v1 5/7] ACPI: scan: Add ACPI device "enumerated" marker

[sashiko-bot@kernel.org]

> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> Currently, the "visited" flag of ACPI device objects has two roles.
> One of them is to indicate that the given ACPI device object has been
> enumerated, which basically means that either it has been associated
> with a "physical" device representation, or there is no matching
> "physical" device representation for it.  The other one is to
> indicate that acpi_bus_attach() has processed the device.  That dual
> purpose leads to some confusion regarding when that flag should be set
> and cleared and by whom.
> 
> To address that confusion, add a new bool field called "enumerated"
> to struct acpi_device for the purpose of indicating whether or not
> the given ACPI device object has been enumerated.  Accordingly, switch
> over acpi_device_enumerated() and acpi_device_set/clear_enumerated() to
> [ ... ]
> 
> This allows a couple of checks to be dropped from acpi_bus_attach()
> and its first_pass argument is not needed any more.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/3435655.aeNJFYEL58@rafael.j.wysocki?part=5