Re: [RFC PATCH 15/19] vfio/pci: Add INTx helpers for PCI recovery

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] vfio_pci_intx_recovery_command() unconditionally sets PCI_COMMAND_INTX_DISABLE without checking if the device supports PCI 2.3 INTx masking.
--

commit e9304e8881d7f9626b1abc86dddca1139e91674f
Author: Shameer Kolothum <skolothumtho@nvidia.com>

vfio/pci: Add INTx helpers for PCI recovery

This commit adds helpers the recovery callbacks need to keep INTx in step
with an error event, and the two per-context flags they record it in.

> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index 64f80f64ff57a..c4a075b5bb2e3 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c

[ ... ]

> @@ -247,6 +283,86 @@ static irqreturn_t vfio_intx_handler(int irq, void *dev_id)
>  	return ret;
>  }

[ ... ]

> +u16 vfio_pci_intx_recovery_command(struct vfio_pci_core_device *vdev,
> +				   u16 command)
> +{
> +	struct vfio_pci_irq_ctx *ctx;
> +
> +	lockdep_assert_held(&vdev->irqlock);
> +
> +	if (!is_intx(vdev))
> +		return command;
> +
> +	ctx = vfio_irq_ctx_get(vdev, 0);
> +	if (ctx && ctx->masked)
> +		command |= PCI_COMMAND_INTX_DISABLE;

[Severity: High]
Is it safe to unconditionally set PCI_COMMAND_INTX_DISABLE here without
checking if the device supports PCI 2.3 INTx masking?

If a host PCI error recovery operation calls vfio_pci_intx_recovery_command()
on a legacy PCI device (where vdev->pci_2_3 is false) whose INTx is currently
masked, this erroneously adds the INTX_DISABLE bit to the saved command word.

Writing to reserved bits in the PCI Command Register on legacy devices
(pre-PCI 2.3) can cause undefined behavior or hardware malfunction. Should
this check vdev->pci_2_3 before setting the disable bit, since other INTx
handling paths in this subsystem correctly verify it?

> +
> +	return command;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901093217.8539-1-skolothumtho@nvidia.com?part=15