Re: [PATCH v5 2/6] PCI: spacemit-k1: Add multiple PHY handles support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch uses non-existent PHY bulk APIs (`struct phy_bulk_data`, `devm_of_phy_bulk_get_all`, `phy_bulk_init`, `phy_bulk_exit`), which will cause an immediate build failure.
--

commit fe08b64098d53a53f4787c86d1612302f802dee7
Author: Inochi Amaoto <inochiama@gmail.com>

PCI: spacemit-k1: Add multiple PHY handles support

This commit extends the Spacemit K1 PCIe controller driver to support
multiple PHY handles by introducing bulk PHY API calls. It replaces single
PHY operations with bulk operations throughout the driver's initialization
and cleanup paths.

> diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> index 9512556d45390..1049391beee83 100644
> --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> @@ -51,12 +51,14 @@ struct k1_pcie_device_data {
>  	const struct dw_pcie_host_ops *host_ops;
>  	const struct dw_pcie_ops *ops;
>  	int (*parse_port)(struct k1_pcie *k1);
> +	unsigned int max_phy_count;
>  };
>  
>  struct k1_pcie {
>  	struct dw_pcie pci;
>  	const struct k1_pcie_device_data *data;
> -	struct phy *phy;
> +	struct phy_bulk_data *phys;

[Severity: Low]
Does struct phy_bulk_data exist in the kernel? It appears this type is
undefined, which will cause a build failure here in k1_pcie.

> +	unsigned int phy_count;
>  	void __iomem *link;
>  	struct regmap *pmu;	/* Errors ignored; MMIO-backed regmap */

[ ... ]

> @@ -115,6 +117,23 @@ static void k1_pcie_disable_resources(struct k1_pcie *k1)
>  	clk_bulk_disable_unprepare(ARRAY_SIZE(pci->app_clks), pci->app_clks);
>  }
>  
> +static int k1_pcie_get_phy_handle(struct k1_pcie *k1, struct device_node *node)
> +{
> +	const struct k1_pcie_device_data *data = k1->data;
> +	struct device *dev = k1->pci.dev;
> +	int count;
> +
> +	count = devm_of_phy_bulk_get_all(dev, node, &k1->phys);

[Severity: Low]
Is devm_of_phy_bulk_get_all() an upstream API? I'm unable to find this
function, and calling an undefined function will break the build during
k1_pcie_get_phy_handle().

> +	if (count < 0)
> +		return count;
> +	if (count == 0 || count > data->max_phy_count)
> +		return -EINVAL;
> +
> +	k1->phy_count = count;
> +
> +	return 0;
> +}
> +
>  /* FIXME: Disable ASPM L1 to avoid errors reported on some NVMe drives */
>  static void k1_pcie_disable_aspm_l1(struct k1_pcie *k1)

[ ... ]

> @@ -170,7 +189,7 @@ static int k1_pcie_init(struct dw_pcie_rp *pp)
>  	 */
>  	regmap_set_bits(k1->pmu, reset_ctrl, DEVICE_TYPE_RC | PCIE_AUX_PWR_DET);
>  
> -	ret = phy_init(k1->phy);
> +	ret = phy_bulk_init(k1->phy_count, k1->phys);

[Severity: Low]
Is phy_bulk_init() defined? Similar to the other bulk APIs used in this patch,
this appears to be an undefined function and will fail compilation in
k1_pcie_init().

>  	if (ret) {
>  		k1_pcie_disable_resources(k1);
>  
> @@ -195,7 +214,7 @@ static void k1_pcie_deinit(struct dw_pcie_rp *pp)
>  	regmap_set_bits(k1->pmu, k1->pmu_off + PCIE_CLK_RESET_CONTROL,
>  			PCIE_RC_PERST);
>  
> -	phy_exit(k1->phy);
> +	phy_bulk_exit(k1->phy_count, k1->phys);

[Severity: Low]
Does phy_bulk_exit() exist? Like the initialization function, this seems to be
undefined and will cause compilation to fail during k1_pcie_deinit().

>  
>  	k1_pcie_disable_resources(k1);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907112606.465778-1-inochiama@gmail.com?part=2