Re: [PATCH v5 5/6] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `spacemit,k3-pcie` compatible string lacks a requirement for any interrupt mechanism, allowing incomplete device tree nodes to silently pass schema validation.
--

commit 92cb9c20a16a6dc1a934eea83a6f78a972ade969
Author: Inochi Amaoto <inochiama@gmail.com>

dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller

This commit adds device tree binding support for the SpacemiT K3 PCIe
controller, modifying the existing K1 binding. It splits register
constraints and interrupt requirements between the two hardware generations.

> diff --git a/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml b/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
> index c4c00b5fcdc0c..54817d6fd9afe 100644
> --- a/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
[ ... ]
> +allOf:
> +  - $ref: /schemas/pci/snps,dw-pcie.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: spacemit,k1-pcie
> +    then:
[ ... ]
> +      required:
> +        - interrupts
> +        - interrupt-names
> +    else:
> +      properties:
> +        reg:
> +          minItems: 5
> +
> +        reg-names:
> +          minItems: 5

[Severity: Medium]
Does the spacemit,k3-pcie compatible lack a requirement for an interrupt
mechanism here?

Because this patch removes interrupts and interrupt-names from the global
required list (moved to the then block above), a device tree node for
spacemit,k3-pcie that completely lacks interrupt or MSI routing properties
like msi-parent will silently pass schema validation.

However, the system will fail at runtime because the PCIe host controller
requires an interrupt mechanism. Should a required list including msi-parent
be added to this else block to ensure incomplete device tree nodes are
caught during validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907112606.465778-1-inochiama@gmail.com?part=5