From: Fahmy Hassan <fahmymohammed@gmail.com>
To: helgaas@kernel.org, bhelgaas@google.com, scott@spiteful.org
Cc: fahmymohammed@gmail.com, kees@kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH v2 0/5] PCI: hotplug: Check pci_hp_add_bridge() return value
Date: Tue, 8 Sep 2026 20:22:21 -0600 [thread overview]
Message-ID: <20260909022227.620217-1-fahmymohammed@gmail.com> (raw)
In-Reply-To: <20260909014143.GA123333@bhelgaas>
This is v2 of a fix originally sent as a single-driver patch against
cpqphp. Bjorn pointed out that pci_hp_add_bridge() is called unchecked
by four other hotplug drivers too, and asked that this be reviewed as
one series rather than driver by driver, so v2 expands the fix to
cover all five callers: cpqphp, cpcihp, ibmphp, pciehp, and shpchp.
Each patch checks the return value and logs via that driver's own
existing error macro, and removes the corresponding now-resolved TODO
entry where one existed.
v1 -> v2:
- Expanded from a single cpqphp patch to all five drivers that call
pci_hp_add_bridge(), per Bjorn's review.
- Fixed the TODO removal that was missing from the v1 patch email
(a stale archived patch file on my end, not a dropped hunk).
- Reworded the commit messages: pci_hp_add_bridge() already logs one
of its two failure paths (no bus number available) via pci_err();
only the other path (subordinate bus not created after scanning)
was actually unreported. v1's message overstated this as
"completely unreported".
Fahmy Hassan (5):
PCI: cpqphp: Check pci_hp_add_bridge() return value
PCI: cpcihp: Check pci_hp_add_bridge() return value
PCI: ibmphp: Check pci_hp_add_bridge() return value
PCI: pciehp: Check pci_hp_add_bridge() return value
PCI: shpchp: Check pci_hp_add_bridge() return value
drivers/pci/hotplug/TODO | 8 --------
drivers/pci/hotplug/cpci_hotplug_pci.c | 5 +++--
drivers/pci/hotplug/cpqphp_pci.c | 4 +++-
drivers/pci/hotplug/ibmphp_core.c | 3 ++-
drivers/pci/hotplug/pciehp_pci.c | 3 ++-
drivers/pci/hotplug/shpchp_pci.c | 5 +++--
6 files changed, 13 insertions(+), 15 deletions(-)
--
2.53.0
next prev parent reply other threads:[~2026-09-09 2:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 1:30 [PATCH v1] PCI: cpqphp: Check pci_hp_add_bridge() return value Fahmy Hassan
2026-09-09 1:41 ` Bjorn Helgaas
2026-09-09 2:17 ` Fahmy Hassan
2026-09-09 2:22 ` Fahmy Hassan [this message]
2026-09-09 2:22 ` [PATCH v2 1/5] " Fahmy Hassan
2026-09-09 2:22 ` [PATCH v2 2/5] PCI: cpcihp: " Fahmy Hassan
2026-09-09 2:22 ` [PATCH v2 3/5] PCI: ibmphp: " Fahmy Hassan
2026-09-09 2:22 ` [PATCH v2 4/5] PCI: pciehp: " Fahmy Hassan
2026-09-09 6:42 ` Lukas Wunner
2026-09-09 2:22 ` [PATCH v2 5/5] PCI: shpchp: " Fahmy Hassan
2026-09-09 1:42 ` [PATCH v1] PCI: cpqphp: " sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909022227.620217-1-fahmymohammed@gmail.com \
--to=fahmymohammed@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox