Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Navon John Lukose" <navonjohnlukose@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH wireless v3 3/4] wifi: iwlwifi: pcie: deselect the product reset mode at probe
Date: Sun, 13 Sep 2026 21:19:30 +0000	[thread overview]
Message-ID: <20260913211930.BC6341F000FF@smtp.kernel.org> (raw)
In-Reply-To: <c370900547aa57b4397e5ea9b7b456b82256ddea.1789333511.git.navonjohnlukose@gmail.com>

> The product reset mode lives in the platform's ACPI namespace, so it
> outlives the trans that set it. _RST branches on it and does not clear it,
> and the deselect in iwl_trans_pcie_removal_wk() is a DSM that fails once
> the device is off the bus, so a later request for a function level reset
> can get a full product reset instead, with Bluetooth still bound. Deselect
> it at probe.
> 
> Cc: stable@vger.kernel.org
> Fixes: 9673c35486d4 ("wifi: iwlwifi: implement product reset for TOP errors")
> Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1789333511.git.navonjohnlukose@gmail.com?part=3


  reply	other threads:[~2026-09-13 21:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 21:14 [PATCH wireless v3 0/4] wifi: iwlwifi: recover the BE200 after D3cold removes its power Navon John Lukose
2026-09-13 21:14 ` [PATCH wireless v3 1/4] wifi: iwlwifi: pcie: cancel the ME recheck work on probe failure Navon John Lukose
2026-09-13 21:20   ` sashiko-bot
2026-09-13 21:14 ` [PATCH wireless v3 2/4] wifi: iwlwifi: pcie: don't infer CSME presence from a failed read Navon John Lukose
2026-09-13 21:22   ` sashiko-bot
2026-09-13 21:14 ` [PATCH wireless v3 3/4] wifi: iwlwifi: pcie: deselect the product reset mode at probe Navon John Lukose
2026-09-13 21:19   ` sashiko-bot [this message]
2026-09-13 21:14 ` [PATCH wireless v3 4/4] wifi: iwlwifi: pcie: recover a device that lost power in D3cold Navon John Lukose
2026-09-13 21:21   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260913211930.BC6341F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=navonjohnlukose@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox