Re: [PATCH wireless v3 4/4] wifi: iwlwifi: pcie: recover a device that lost power in D3cold

[sashiko-bot@kernel.org]

> On some boards D3cold cuts a discrete module's power rail and the device
> never comes back. The link does not train and config space reads all ones
> until reboot.
> 
> The product reset the driver already implements recovers it, but the vendor
> DSM that selects the product reset mode reads the device's PCI ID out of
> config space first, so it can only be armed while the device still answers.
> iwl_trans_pcie_removal_wk(), the only place that arms it, is too late.
> 
> Arm it in .suspend and disarm in .resume. If the disarm fails and
> CSR_HW_REV reads all ones, run the product reset. Skip integrated CNVi,
> whose DSM takes an AML path I cannot test. The DSM failure log drops to
> debug, since .suspend would otherwise hit it on every suspend on boards
> without the DSM.
> 
> Cc: stable+noautosel@kernel.org # new suspend/resume behaviour, one machine
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=221695
> Link: https://lore.kernel.org/all/20260722021321.68902-1-nika@nikableh.moe/
> Link: https://lore.kernel.org/all/20260829093922.37103-1-navonjohnlukose@gmail.com/
> Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1789333511.git.navonjohnlukose@gmail.com?part=4