[PATCH] PCI: qcom-ep: deinitialize endpoint on remove

[PATCH] PCI: qcom-ep: deinitialize endpoint on remove

[Guangshuo Li]

qcom_pcie_ep_probe() initializes the DesignWare PCIe endpoint with
dw_pcie_ep_init(). The probe failure paths call dw_pcie_ep_deinit() to
release the corresponding endpoint resources, but the remove path does
not perform the matching teardown after a successful probe.

As a result, resources initialized by the DesignWare endpoint core can
remain allocated when the endpoint controller is removed.

Notify endpoint functions about EPC deinitialization and call
dw_pcie_ep_deinit() before disabling the controller resources. Keep the
existing early return when the link is already disabled since Qualcomm
endpoint controllers depend on the host refclk for hardware cleanup.

This issue was found by manual code inspection.

Fixes: f55fee56a631 ("PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
 drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
index 56184e6ca6e6..28949386b0e8 100644
--- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
+++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
@@ -944,6 +944,8 @@ static void qcom_pcie_ep_remove(struct platform_device *pdev)
 
 	if (pcie_ep->link_status == QCOM_PCIE_EP_LINK_DISABLED)
 		return;
+	pci_epc_deinit_notify(pcie_ep->pci.ep.epc);
+	dw_pcie_ep_deinit(&pcie_ep->pci.ep);
 
 	qcom_pcie_disable_resources(pcie_ep);
 }
-- 
2.43.0

Re: [PATCH] PCI: qcom-ep: deinitialize endpoint on remove

[sashiko-bot]

> qcom_pcie_ep_probe() initializes the DesignWare PCIe endpoint with
> dw_pcie_ep_init(). The probe failure paths call dw_pcie_ep_deinit() to
> release the corresponding endpoint resources, but the remove path does
> not perform the matching teardown after a successful probe.
> 
> As a result, resources initialized by the DesignWare endpoint core can
> remain allocated when the endpoint controller is removed.
> 
> Notify endpoint functions about EPC deinitialization and call
> dw_pcie_ep_deinit() before disabling the controller resources. Keep the
> existing early return when the link is already disabled since Qualcomm
> endpoint controllers depend on the host refclk for hardware cleanup.
> 
> This issue was found by manual code inspection.
> 
> Fixes: f55fee56a631 ("PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916090126.2963064-1-lgs201920130244@gmail.com?part=1