From: sashiko-bot@kernel.org
To: "Nirmoy Das" <nirmoyd@nvidia.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH v2] PCI: Work around Pericom PI7C9X3G606GPC Port 4 BAR erratum
Date: Thu, 17 Sep 2026 10:49:24 +0000 [thread overview]
Message-ID: <20260917104925.1CB0C1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917103814.1985144-1-nirmoyd@nvidia.com>
> When the Cross-Domain End-Point (CDEP) function is disabled on the
> Pericom PI7C9X3G606GPC, Port 4 exposes neither a BAR resource nor an
> MSI-X capability. It still checks memory requests against
> BAR 0 + 0x7f000 and BAR 0 + 0x7f080, the MSI-X Table and PBA addresses.
> With the internal BAR value at zero, reads reaching Port 4 at these
> addresses receive Unsupported Request (UR) Completions.
>
> The affected system has this topology:
>
> 0002:a1:00.0 PI7C9X3G606GPC upstream port [12d8:c008]
> +-0002:a2:04.0 PI7C9X3G606GPC Port 4 [12d8:c008]
> +-0002:a3:00.0 Micron 7450 PRO NVMe SSD [1344:51c3]
>
> Diodes' workaround is to copy the upstream port's BAR 0 into Port 4.
> This places the Table and PBA addresses within MMIO space already
> allocated to the switch. Port 4 accepts the write but still returns
> zero on config-space reads, so readback cannot verify the mirror.
>
> Firmware can apply the workaround during boot, but Linux BAR sizing
> reads zero from Port 4 and writes that zero back after probing.
> Resource assignment can also move the upstream BAR 0, leaving the
> firmware mirror stale.
>
> Reapply the mirror after resource assignment and again after PCI
> configuration state is restored during early resume. If the upstream
> BAR is 64-bit, also copy BAR 1 and disable memory decoding while
> updating both halves, unless mmio_always_on is set.
>
> Assisted-by: Codex:GPT-5
> Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917103814.1985144-1-nirmoyd@nvidia.com?part=1
prev parent reply other threads:[~2026-09-17 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 16:10 [RFC PATCH] PCI: Work around Pericom PI7C9X3G606GPC Port 4 BAR erratum Nirmoy Das
2026-07-23 16:16 ` sashiko-bot
2026-07-23 20:54 ` Bjorn Helgaas
2026-07-24 8:36 ` JC Chen[陳饒靜]
2026-08-26 14:28 ` Ilpo Järvinen
2026-08-27 0:13 ` JC Chen[陳饒靜]
2026-08-27 6:45 ` JC Chen[陳饒靜]
2026-08-31 15:29 ` Nirmoy Das
2026-09-01 2:51 ` JC Chen[陳饒靜]
2026-09-02 19:08 ` Nirmoy Das
2026-09-17 10:38 ` [RFC PATCH v2] " Nirmoy Das
2026-09-17 10:49 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917104925.1CB0C1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nirmoyd@nvidia.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox