Re: [PATCH v2 02/10] PCI/AER: Clamp negative ratelimit burst to zero

[sashiko-bot@kernel.org]

> The correctable and nonfatal "_ratelimit_burst" attributes store
> whatever kstrtoint() parses, so a negative value lands directly in
> ratelimit_state.burst.
> 
> ___ratelimit() reads a negative burst as an uninitialized
> ratelimit_state and splats a WARN_ONCE. A CAP_SYS_ADMIN write of "-1"
> then warns on the next AER error and suppresses every later message,
> with nothing in the attribute to show that logging is off.
> 
> Clamp negative values to zero, as the companion interval attribute
> already does. Zero still suppresses everything, so a negative value
> keeps its old meaning without the warning.
> 
> Document that in the ABI description of both burst attributes. Document
> it for the interval attributes too, where clamping negatives is existing
> behaviour that was never written down.
> 
> Fixes: b4fe7398def6 ("PCI/AER: Add sysfs attributes for log ratelimits")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/linux-pci/20260714191826.BA81E1F000E9@smtp.kernel.org/
> Assisted-by: LLM
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918145619.3016889-1-yazen.ghannam@amd.com?part=2