Re: [PATCH v10 4/6] PCI: Refactor disable_acs_redir and config_acs param handling

[sashiko-bot@kernel.org]

> The current implementation mixes disable_acs_redir and config_acs param
> processing inside __pci_config_acs(), using acs_mask==0 as an implicit
> signal to switch into config_acs_param mode. The intertwined logic is
> hard to follow and easy to break:
> 
>   - The acs_mask==0 special case is non-obvious and obscures which code
>     paths apply to which parameter.
>   - The interleaved logic is fragile; changes intended for one parameter
>     can unintentionally affect the other. For example,
>     pci_dev_specific_disable_acs_redir() is invoked on the common path
>     even though it should apply only to disable_acs_redir.
> 
> Split the two behaviors into dedicated functions,
> pci_param_disable_acs_redir() and pci_param_config_acs(), making the
> control flow explicit and easier to maintain.
> [ ... ]
> 
> This refactor separates concerns, improves robustness, and makes future
> extensions to ACS parameter handling safer and easier to review.
> 
> Signed-off-by: Wei Wang <wei.w.wang@hotmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/SI2PR01MB43935D2C01946E6D8FD9EFAADC832@SI2PR01MB4393.apcprd01.prod.exchangelabs.com?part=4