From: sashiko-bot@kernel.org
To: "Wei Wang" <wei.w.wang@hotmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v10 6/6] PCI: Add the enhanced ACS controls check to pci_acs_flags_enabled()
Date: Tue, 22 Sep 2026 15:14:43 +0000 [thread overview]
Message-ID: <20260922151443.E7D7E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <SI2PR01MB439336B71D997B10A96651E5DC832@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>
> The enhanced ACS controls introduced by PCIe Gen 5 ensures better device
> isolation. On devices that support the PCI_ACS_ECAP capability, the
> controls are required to be enabled properly:
> - ACS I/O Request Blocking needs to be enabled to avoid unintended
> upstream I/O requests.
> - ACS DSP and USP Memory Target Access Control needs to be set with
> Request Redirect or Request Blocking to ensure the Downstream and
> Upstream Port memory resource ranges are not accessed by upstream
> memory requests.
> - ACS Unclaimed Request Redirect needs to be enabled to ensure accesses to
> areas that lies within a Switch's Upstream Port memory apertures but not
> within any Downstream Port memory apertures get redirected.
>
> To maintain compatibility with legacy devices that lack PCI_ACS_ECAP
> support, pci_acs_enabled() skips checking for the capability.
>
> Signed-off-by: Wei Wang <wei.w.wang@hotmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/SI2PR01MB43935D2C01946E6D8FD9EFAADC832@SI2PR01MB4393.apcprd01.prod.exchangelabs.com?part=6
prev parent reply other threads:[~2026-09-22 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 15:02 [PATCH v10 0/6] PCI: Add support for ACS Enhanced Capability Wei Wang
2026-09-22 15:02 ` [PATCH v10 1/6] PCI: Validate ACS control bits against device-specific ACS capabilities Wei Wang
2026-09-22 15:12 ` sashiko-bot
2026-09-22 15:02 ` [PATCH v10 2/6] Documentation/kernel-parameters: Add multi-device config_acs example Wei Wang
2026-09-22 15:13 ` sashiko-bot
2026-09-22 15:02 ` [PATCH v10 3/6] PCI: Consolidate delimiter handling into pci_dev_str_match() Wei Wang
2026-09-22 15:09 ` sashiko-bot
2026-09-22 15:02 ` [PATCH v10 4/6] PCI: Refactor disable_acs_redir and config_acs param handling Wei Wang
2026-09-22 15:13 ` sashiko-bot
2026-09-22 15:02 ` [PATCH v10 5/6] PCI: Enable the enhanced ACS controls introduced by PCI_ACS_ECAP Wei Wang
2026-09-22 15:14 ` sashiko-bot
2026-09-22 15:02 ` [PATCH v10 6/6] PCI: Add the enhanced ACS controls check to pci_acs_flags_enabled() Wei Wang
2026-09-22 15:14 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922151443.E7D7E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wei.w.wang@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox