Re: [PATCH v4 15/22] lib: rspdm: Support SPDM get_version

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Duplicate documentation paragraph for SpdmState
--

commit 9b95322ccfb4a7875669dc07aadddb7266aa7fc7
Author: Alistair Francis <alistair@alistair23.me>

lib: rspdm: Support SPDM get_version

This commit introduces support for the GET_VERSION SPDM command in the Rust
SPDM implementation. It implements version parsing and validates responses
during authentication.

> diff --git a/lib/rspdm/state.rs b/lib/rspdm/state.rs
> index c894cf30bb870..3bbe55d965f7a 100644
> --- a/lib/rspdm/state.rs
> +++ b/lib/rspdm/state.rs

[ ... ]

> @@ -37,6 +41,11 @@
>  /// run one at a time and the locked `&mut SpdmState` is the only way to
>  /// reach the inner fields.
>  ///
> +/// Concurrent access is serialized by wrapping the whole struct in a
> +/// `Mutex<SpdmState>` at the FFI boundary, so `spdm_authenticate()` callers
> +/// run one at a time and the locked `&mut SpdmState` is the only way to
> +/// reach the inner fields.
> +///

[Severity: Low]
Does this documentation paragraph need to be duplicated?

It looks like this newly added text is an exact duplicate of the preceding
paragraph explaining the concurrent access model of SpdmState.

>  /// `dev`: Responder device.  Used for error reporting and passed to @transport.
>  /// `transport`: Transport function to perform one message exchange.
>  /// `transport_priv`: Transport private data.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928011123.450800-1-alistair.francis@wdc.com?part=15