* [PATCH] PCI: dwc: Describe DWC PCIe fields with full masks and FIELD_PREP()
@ 2026-09-30 1:38 Hans Zhang
2026-09-30 1:45 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Hans Zhang @ 2026-09-30 1:38 UTC (permalink / raw)
To: bhelgaas, lpieralisi, kwilczynski, mani, jingoohan1
Cc: robh, a-garg7, linux-pci, linux-kernel, Hans Zhang
Several DWC PCIe register fields are described with a shift macro next
to their mask, or with only a shift and the field width implied by the
value written. Document the field position and width in a single full
mask and use FIELD_PREP() to encode it.
No functional change intended.
Signed-off-by: Hans Zhang <18255117159@163.com>
---
- Based on the controller/dwc branch.
---
.../pci/controller/dwc/pcie-designware-ep.c | 2 +-
drivers/pci/controller/dwc/pcie-designware.h | 12 ++++------
drivers/pci/controller/dwc/pcie-tegra194.c | 22 +++++++++----------
3 files changed, 16 insertions(+), 20 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
index 0262d85ed390..198823f105c5 100644
--- a/drivers/pci/controller/dwc/pcie-designware-ep.c
+++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
@@ -1077,7 +1077,7 @@ int dw_pcie_ep_raise_msix_irq_doorbell(struct dw_pcie_ep *ep, u8 func_no,
if (!ep_func || !ep_func->msix_cap)
return -EINVAL;
- msg_data = (func_no << MSIX_DOORBELL_PF_SHIFT) |
+ msg_data = FIELD_PREP(MSIX_DOORBELL_PF_MASK, func_no) |
(interrupt_num - 1);
dw_pcie_writel_dbi(pci, MSIX_DOORBELL, msg_data);
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index aea474ad803c..1ff6ed1f9f0b 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -85,9 +85,7 @@
/* Common Clock N_FTS */
#define PORT_AFAC_CC_N_FTS(n) FIELD_PREP(PORT_AFAC_CC_N_FTS_MASK, n)
#define PORT_AFAC_ENTER_ASPM BIT(30) /* ASPM L1 Entry Control */
-#define PORT_AFAC_L0S_ELS 24 /* L0s Entrance Latency shift */
#define PORT_AFAC_L0S_ELM GENMASK(26, 24) /* L0s Entrance Latency mask */
-#define PORT_AFAC_L1_ELS 27 /* L1 Entrance Latency shift */
#define PORT_AFAC_L1_ELM GENMASK(29, 27) /* L1 Entrance Latency mask */
#define PORT_LINK_CTRL 0x710 /* Port Link Control Register */
@@ -161,7 +159,6 @@
#define GEN3_CTRL_EQ_PHASE_2_3 BIT(9) /* Equalization Phase 2 and Phase 3 */
#define GEN3_CTRL_RXEQ_RGRDLESS_RXTS BIT(13)
#define GEN3_CTRL_GEN3_EQ_DISABLE BIT(16) /* Equalization Disable */
-#define GEN3_CTRL_RATE_SHADOW_SEL_SHIFT 24 /* Rate Shadow Select shift */
#define GEN3_CTRL_RATE_SHADOW_SEL_MASK GENMASK(25, 24) /* Rate Shadow Select mask */
#define GEN3_EQ_CTRL 0x8A8 /* Gen3 EQ Control */
@@ -230,7 +227,7 @@
#define ATU_UPPER_LIMIT 0x020
#define MSIX_DOORBELL 0x948
-#define MSIX_DOORBELL_PF_SHIFT 24
+#define MSIX_DOORBELL_PF_MASK GENMASK(28, 24)
/*
* eDMA CSRs. DW PCIe IP-core v4.70a and older had the eDMA registers accessible
@@ -278,15 +275,14 @@
#define RAS_DES_EVENT_COUNTER_CONTROL 0x8
#define EVENT_COUNTER_ALL_CLEAR 0x3
#define EVENT_COUNTER_ENABLE_ALL 0x7
-#define EVENT_COUNTER_ENABLE_SHIFT 2
-#define EVENT_COUNTER_EVENT_SEL_MASK GENMASK(7, 0)
-#define EVENT_COUNTER_EVENT_SEL_SHIFT 16
+#define EVENT_COUNTER_ENABLE_MASK GENMASK(4, 2)
+#define EVENT_COUNTER_EVENT_SEL_MASK GENMASK(23, 16)
+#define EVENT_COUNTER_GROUP_SEL_MASK GENMASK(27, 24)
#define EVENT_COUNTER_EVENT_Tx_L0S 0x2
#define EVENT_COUNTER_EVENT_Rx_L0S 0x3
#define EVENT_COUNTER_EVENT_L1 0x5
#define EVENT_COUNTER_EVENT_L1_1 0x7
#define EVENT_COUNTER_EVENT_L1_2 0x8
-#define EVENT_COUNTER_GROUP_SEL_SHIFT 24
#define EVENT_COUNTER_GROUP_5 0x5
#define RAS_DES_EVENT_COUNTER_DATA 0xc
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 8c610212a180..285a38178da8 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -622,10 +622,10 @@ static inline u32 event_counter_prog(struct tegra_pcie_dw *pcie, u32 event)
val = dw_pcie_readl_dbi(&pcie->pci, pcie->ras_des_cap +
RAS_DES_EVENT_COUNTER_CONTROL);
- val &= ~(EVENT_COUNTER_EVENT_SEL_MASK << EVENT_COUNTER_EVENT_SEL_SHIFT);
- val |= EVENT_COUNTER_GROUP_5 << EVENT_COUNTER_GROUP_SEL_SHIFT;
- val |= event << EVENT_COUNTER_EVENT_SEL_SHIFT;
- val |= EVENT_COUNTER_ENABLE_ALL << EVENT_COUNTER_ENABLE_SHIFT;
+ val &= ~EVENT_COUNTER_EVENT_SEL_MASK;
+ val |= FIELD_PREP(EVENT_COUNTER_GROUP_SEL_MASK, EVENT_COUNTER_GROUP_5);
+ val |= FIELD_PREP(EVENT_COUNTER_EVENT_SEL_MASK, event);
+ val |= FIELD_PREP(EVENT_COUNTER_ENABLE_MASK, EVENT_COUNTER_ENABLE_ALL);
dw_pcie_writel_dbi(&pcie->pci, pcie->ras_des_cap +
RAS_DES_EVENT_COUNTER_CONTROL, val);
val = dw_pcie_readl_dbi(&pcie->pci, pcie->ras_des_cap +
@@ -661,8 +661,8 @@ static int aspm_state_cnt(struct seq_file *s, void *data)
EVENT_COUNTER_ALL_CLEAR);
/* Re-enable counting */
- val = EVENT_COUNTER_ENABLE_ALL << EVENT_COUNTER_ENABLE_SHIFT;
- val |= EVENT_COUNTER_GROUP_5 << EVENT_COUNTER_GROUP_SEL_SHIFT;
+ val = FIELD_PREP(EVENT_COUNTER_ENABLE_MASK, EVENT_COUNTER_ENABLE_ALL);
+ val |= FIELD_PREP(EVENT_COUNTER_GROUP_SEL_MASK, EVENT_COUNTER_GROUP_5);
dw_pcie_writel_dbi(&pcie->pci, pcie->ras_des_cap +
RAS_DES_EVENT_COUNTER_CONTROL, val);
@@ -680,8 +680,8 @@ static void init_host_aspm(struct tegra_pcie_dw *pcie)
PCI_EXT_CAP_ID_VNDR);
/* Enable ASPM counters */
- val = EVENT_COUNTER_ENABLE_ALL << EVENT_COUNTER_ENABLE_SHIFT;
- val |= EVENT_COUNTER_GROUP_5 << EVENT_COUNTER_GROUP_SEL_SHIFT;
+ val = FIELD_PREP(EVENT_COUNTER_ENABLE_MASK, EVENT_COUNTER_ENABLE_ALL);
+ val |= FIELD_PREP(EVENT_COUNTER_GROUP_SEL_MASK, EVENT_COUNTER_GROUP_5);
dw_pcie_writel_dbi(pci, pcie->ras_des_cap +
RAS_DES_EVENT_COUNTER_CONTROL, val);
@@ -715,9 +715,9 @@ static void init_host_aspm(struct tegra_pcie_dw *pcie)
/* Program L0s and L1 entrance latencies */
val = dw_pcie_readl_dbi(pci, PORT_AFAC);
val &= ~PORT_AFAC_L0S_ELM;
- val |= (pcie->aspm_l0s_enter_lat << PORT_AFAC_L0S_ELS);
+ val |= FIELD_PREP(PORT_AFAC_L0S_ELM, pcie->aspm_l0s_enter_lat);
val &= ~PORT_AFAC_L1_ELM;
- val |= (pcie->aspm_l1_enter_lat << PORT_AFAC_L1_ELS);
+ val |= FIELD_PREP(PORT_AFAC_L1_ELM, pcie->aspm_l1_enter_lat);
val |= PORT_AFAC_ENTER_ASPM;
dw_pcie_writel_dbi(pci, PORT_AFAC, val);
}
@@ -881,7 +881,7 @@ static void config_gen3_gen4_eq_presets(struct tegra_pcie_dw *pcie)
val = dw_pcie_readl_dbi(pci, GEN3_CTRL);
val &= ~GEN3_CTRL_RATE_SHADOW_SEL_MASK;
- val |= (0x1 << GEN3_CTRL_RATE_SHADOW_SEL_SHIFT);
+ val |= FIELD_PREP(GEN3_CTRL_RATE_SHADOW_SEL_MASK, 0x1);
dw_pcie_writel_dbi(pci, GEN3_CTRL, val);
val = dw_pcie_readl_dbi(pci, GEN3_EQ_CTRL);
base-commit: 4996364a46e738cc455f5fa9b8b09f2f3348bcc9
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-30 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-30 1:38 [PATCH] PCI: dwc: Describe DWC PCIe fields with full masks and FIELD_PREP() Hans Zhang
2026-09-30 1:45 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox