Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wei Huang" <wei.huang2@amd.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] PCI/TPH: Factor out the ST _DSM evaluation
Date: Thu, 01 Oct 2026 16:02:31 +0000	[thread overview]
Message-ID: <20261001160232.3B3841F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001155551.4182899-2-wei.huang2@amd.com>

> The ACPI _DSM that returns the CPU to Steering Tag (ST) mapping is
> evaluated in one place today, with the lookup of the ACPI device providing
> it open coded in pcie_tph_get_cpu_st().
> 
> Factor the handle lookup and the per-CPU query into tph_dsm_handle() and
> tph_get_cpu_st_info() so other callers can reuse them, name the _DSM
> revision instead of repeating the bare number, and constify the ST info
> passed to tph_extract_tag().
> 
> No functional change introduced.
> 
> Signed-off-by: Wei Huang <wei.huang2@amd.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001155551.4182899-1-wei.huang2@amd.com?part=1


  reply	other threads:[~2026-10-01 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 15:55 [PATCH RFC 0/3] PCI/TPH: Expose CPU-to-Steering Tag mappings via debugfs Wei Huang
2026-10-01 15:55 ` [PATCH RFC 1/3] PCI/TPH: Factor out the ST _DSM evaluation Wei Huang
2026-10-01 16:02   ` sashiko-bot [this message]
2026-10-01 15:55 ` [PATCH RFC 2/3] PCI: Add per-device debugfs directories Wei Huang
2026-10-01 16:10   ` sashiko-bot
2026-10-01 15:55 ` [PATCH RFC 3/3] Expose the CPU/Steering Tag mapping via debugfs Wei Huang
2026-10-01 16:04   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001160232.3B3841F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wei.huang2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox