From: Konrad Dybcio <konradybcio@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Wunner <lukas@wunner.de>,
mani@kernel.org
Subject: Re: [PATCH v2] PCI: Allow D3 for native Hotplug capable Root Ports on non-x86 platforms
Date: Wed, 2 Sep 2026 19:09:58 +0200 [thread overview]
Message-ID: <3eeb3465-a1e6-4fdc-8019-3907d9c55691@gmail.com> (raw)
In-Reply-To: <20260811232245.GA805297@bhelgaas>
On 8/12/26 1:22 AM, Bjorn Helgaas wrote:
> On Wed, Jul 29, 2026 at 06:50:05PM +0200, Manivannan Sadhasivam wrote:
>> Commit eb3b5bf1a88d ("PCI: Whitelist native hotplug ports for runtime D3"),
>> prevented native Hotplug capable Root Ports from entering D3 citing issues
>> on old Intel SkyLake Xeon-SP platform.
>>
>> But there is no reason to restrict D3 for native Hotplug capable Root
>> Ports on non-x86 platforms. We recently enabled D3 on non-Hotplug capable
>> Root Ports on non-x86 platforms (specifically for DT platforms) in commit
>> a5fb3ff63287 ("PCI: Allow PCI bridges to go to D3Hot on all non-x86"). So
>> do the same for native Hotplug capable Root Ports as well.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> Applied to pci/pm for v7.3, thanks!
This breaks system suspend entry (crashes the system) on Qualcomm SC8280XP
CRD.. this SoC is known for fragile PCIe.
It doesn't repro on e.g. the Qualcomm Glymur CRD (2 gens newer), perhaps we
need an explicit opt-out like
if (of_machine_is_compatible("qcom,sc8280xp"))
or some targetted fix inside the qcom driver
Konrad
next prev parent reply other threads:[~2026-09-02 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 16:50 [PATCH v2] PCI: Allow D3 for native Hotplug capable Root Ports on non-x86 platforms Manivannan Sadhasivam
2026-07-29 16:55 ` sashiko-bot
2026-08-11 23:22 ` Bjorn Helgaas
2026-09-02 17:09 ` Konrad Dybcio [this message]
2026-09-02 18:53 ` Lukas Wunner
2026-09-03 5:35 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eeb3465-a1e6-4fdc-8019-3907d9c55691@gmail.com \
--to=konradybcio@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox