From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Wunner <lukas@wunner.de>,
mani@kernel.org
Subject: Re: [PATCH v2] PCI: Allow D3 for native Hotplug capable Root Ports on non-x86 platforms
Date: Tue, 11 Aug 2026 18:22:45 -0500 [thread overview]
Message-ID: <20260811232245.GA805297@bhelgaas> (raw)
In-Reply-To: <20260729165005.896725-1-manivannan.sadhasivam@oss.qualcomm.com>
On Wed, Jul 29, 2026 at 06:50:05PM +0200, Manivannan Sadhasivam wrote:
> Commit eb3b5bf1a88d ("PCI: Whitelist native hotplug ports for runtime D3"),
> prevented native Hotplug capable Root Ports from entering D3 citing issues
> on old Intel SkyLake Xeon-SP platform.
>
> But there is no reason to restrict D3 for native Hotplug capable Root
> Ports on non-x86 platforms. We recently enabled D3 on non-Hotplug capable
> Root Ports on non-x86 platforms (specifically for DT platforms) in commit
> a5fb3ff63287 ("PCI: Allow PCI bridges to go to D3Hot on all non-x86"). So
> do the same for native Hotplug capable Root Ports as well.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Applied to pci/pm for v7.3, thanks!
> ---
>
> Changes in v2:
>
> * Switched to CONFIG_X86 check instead of of_have_populated_dt() as per comments
> from Lukas.
>
> drivers/pci/pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 77b17b13ee61..94f8a4da6009 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3020,11 +3020,11 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge)
> return true;
>
> /*
> - * Hotplug ports handled natively by the OS were not validated
> - * by vendors for runtime D3 at least until 2018 because there
> - * was no OS support.
> + * Hotplug ports handled natively by the OS on x86 platforms
> + * were not validated by vendors for runtime D3 at least until
> + * 2018 because there was no OS support.
> */
> - if (bridge->is_pciehp)
> + if (IS_ENABLED(CONFIG_X86) && bridge->is_pciehp)
> return false;
>
> if (dmi_check_system(bridge_d3_blacklist))
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-08-11 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 16:50 [PATCH v2] PCI: Allow D3 for native Hotplug capable Root Ports on non-x86 platforms Manivannan Sadhasivam
2026-07-29 16:55 ` sashiko-bot
2026-08-11 23:22 ` Bjorn Helgaas [this message]
2026-09-02 17:09 ` Konrad Dybcio
2026-09-02 18:53 ` Lukas Wunner
2026-09-03 5:35 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811232245.GA805297@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox