Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Klaus Doth <kdlnx@doth.eu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	冯锐 <rui_feng@realsil.com.cn>
Subject: [PATCH v3] misc: rtsx: Add short delay after exit from ASPM
Date: Fri, 22 May 2020 12:56:04 +0200	[thread overview]
Message-ID: <4434eaa7-2ee3-a560-faee-6cee63ebd6d4@doth.eu> (raw)
In-Reply-To: <CAK8P3a0YwMJmTimtj0_KfKaPuPs3SMvUgj4eDow1jp8CY5Ugng@mail.gmail.com>

From: Klaus Doth <kdlnx@doth.eu>

DMA transfers to and from the SD card stall for 10 seconds and run into
timeout on RTS5260 card readers after ASPM was enabled.

Adding a short msleep after disabling ASPM fixes the issue on several
Dell Precision 7530/7540 systems I tested.

This function is only called when waking up after the chip went into
power-save after not transferring data for a few seconds. The added
msleep does therefore not change anything in data transfer speed or
induce any excessive waiting while data transfers are running, or the
chip is sleeping. Only the transition from sleep to active is affected.

Signed-off-by: Klaus Doth <kdlnx@doth.eu>
---
Changes from v2:
  - Added this changelog. Tabs should now be tabs instead of spaces.

Changes from v1:
  - Added comment explaining why the msleep is required

 drivers/misc/cardreader/rtsx_pcr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/misc/cardreader/rtsx_pcr.c b/drivers/misc/cardreader/rtsx_pcr.c
index 06038b325b02..3a6a6988cf80 100644
--- a/drivers/misc/cardreader/rtsx_pcr.c
+++ b/drivers/misc/cardreader/rtsx_pcr.c
@@ -141,6 +141,9 @@ static void rtsx_comm_pm_full_on(struct rtsx_pcr *pcr)
 	struct rtsx_cr_option *option = &pcr->option;
 
 	rtsx_disable_aspm(pcr);
+	
+	/* Fixes DMA transfer timout issue after disabling ASPM on RTS5260 */
+	msleep(1);
 
 	if (option->ltr_enabled)
 		rtsx_set_ltr_latency(pcr, option->ltr_active_latency);
-- 
2.26.2


  parent reply	other threads:[~2020-05-22 10:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 17:04 Possible bug in drivers/misc/cardreader/rtsx_pcr.c Klaus Doth
2020-05-21  8:52 ` Greg Kroah-Hartman
2020-05-21 11:50   ` Klaus Doth
2020-05-21 17:59     ` Bjorn Helgaas
2020-05-22  7:33     ` Greg Kroah-Hartman
2020-05-22  8:23   ` [PATCH] misc: rtsx: Add short delay after exit from ASPM Klaus Doth
2020-05-22  8:33     ` Arnd Bergmann
2020-05-22  9:18       ` [PATCH v2] " Klaus Doth
2020-05-22  9:38         ` Greg Kroah-Hartman
2020-05-22 10:56       ` Klaus Doth [this message]
2020-05-22 11:27         ` [PATCH v3] " Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4434eaa7-2ee3-a560-faee-6cee63ebd6d4@doth.eu \
    --to=kdlnx@doth.eu \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rui_feng@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox