Re: [PATCH] PCI: cadence: Kconfig: change PCIE_CADENCE configs from tristate to bool

["Arnd Bergmann" <arnd@arndb.de>]

On Mon, Nov 17, 2025, at 10:23, Siddharth Vadapalli wrote:
> On Mon, 2025-11-17 at 10:06 +0100, Arnd Bergmann wrote:
>> On Mon, Nov 17, 2025, at 07:05, Siddharth Vadapalli wrote:
>> 
>> but you may want to split it up further to get better dead
>> code elimination and prevent similar bugs from reappearing when
>> another call gets added without this type of check.
>> 
>> If you split j721e_pcie_driver into a host and an ep driver
>> structure with their own probe/remove callbacks, you can
>> move the IS_ENABLED() check all the way into module_init()
>> function.
>
> Thank you for the suggestion :)
>
> Would it work if I send a quick fix for `cdns_pcie_host_disable` using
> IS_ENABLED in the existing driver implementation and then send the
> refactoring series later? This is to resolve the build error quickly until
> the refactoring series is ready.
>
> On the other hand, if it should be fixed the right way by refactoring, I
> will not post the temporary fix. Please let me know.

Please see if my suggestion works in practice using all the
combinations of build options, I may have missed something.
If it fixes all the build failures, merging and backporting
this first makes sense.

     Arnd