Re: [PATCH] PCI: cadence: Kconfig: change PCIE_CADENCE configs from tristate to bool

[Hans Zhang <hans.zhang@cixtech.com>]

On 11/13/2025 6:43 PM, Siddharth Vadapalli wrote:
> EXTERNAL EMAIL
> 
> On Thu, 2025-11-13 at 18:38 +0800, Hans Zhang wrote:
>> Hi Siddharth,
>>
>>
>> Your patch repeats this part.
> 
> I am not sure I understand the "repetition" that you are referring to. The
> patch below is updating:
> PCIE_CADENCE_PLAT, PCIE_CADENCE_PLAT_HOST and PCIE_CADENCE_PLAT_EP
> from 'bool' to 'tristate'.
> 
> The current patch is updating:
> PCIE_CADENCE, PCIE_CADENCE_HOST and PCIE_CADENCE_EP
> [No 'PLAT' in the configs]
> from 'tristate' to 'bool'.
> 
Hi Siddharth,

Sorry, I was mistaken.

Best regards,
Hans

>>
>>
>> https://patchwork.kernel.org/project/linux-pci/patch/20251108140305.1120117-2-hans.zhang@cixtech.com/
>>
>> Best regards,
>> Hans
>>
>> On 11/13/2025 5:27 PM, Siddharth Vadapalli wrote:
>>> EXTERNAL EMAIL
>>>
>>> The drivers associated with the PCIE_CADENCE, PCIE_CADENCE_HOST AND
>>> PCIE_CADENCE_EP configs are used by multiple vendor drivers and serve as a
>>> library of helpers. Since the vendor drivers could individually be built
>>> as built-in or as loadable modules, it is possible to select a build
>>> configuration wherein a vendor driver is built-in while the library is
>>> built as a loadable module. This will result in a build error as reported
>>> in the 'Closes' link below.
>>>
>>> Address the build error by changing the library configs to be 'bool'
>>> instead of 'tristate'.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202511111705.MZ7ls8Hm-lkp@intel.com/
>>> Fixes: 1c72774df028 ("PCI: sg2042: Add Sophgo SG2042 PCIe driver")
>>> Cc: <stable@vger.kernel.org>
>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>> ---
>>>    drivers/pci/controller/cadence/Kconfig | 6 +++---
>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig
>>> index 02a639e55fd8..980da64ce730 100644
>>> --- a/drivers/pci/controller/cadence/Kconfig
>>> +++ b/drivers/pci/controller/cadence/Kconfig
>>> @@ -4,16 +4,16 @@ menu "Cadence-based PCIe controllers"
>>>           depends on PCI
>>>
>>>    config PCIE_CADENCE
>>> -       tristate
>>> +       bool
>>>
>>>    config PCIE_CADENCE_HOST
>>> -       tristate
>>> +       bool
>>>           depends on OF
>>>           select IRQ_DOMAIN
>>>           select PCIE_CADENCE
>>>
>>>    config PCIE_CADENCE_EP
>>> -       tristate
>>> +       bool
>>>           depends on OF
>>>           depends on PCI_ENDPOINT
>>>           select PCIE_CADENCE
>>> --
>>> 2.51.1
>>>
>>>
> 
> Regards,
> Siddharth.