[PATCH 1/1] PCI: dwc: reduce log severity level if no link came up

[PATCH 1/1] PCI: dwc: reduce log severity level if no link came up

[Alexander Stein]

Commit 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
changed the severity from info to error. If no device is attached this
error always is recorded which is not an error in this case.

Fixes: 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/pci/controller/dwc/pcie-designware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 9e4d96e5a3f5a..432aead68d1fd 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -448,7 +448,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
 	}
 
 	if (retries >= LINK_WAIT_MAX_RETRIES) {
-		dev_err(pci->dev, "Phy link never came up\n");
+		dev_info(pci->dev, "Phy link never came up\n");
 		return -ETIMEDOUT;
 	}
 
-- 
2.34.1

Re: [PATCH 1/1] PCI: dwc: reduce log severity level if no link came up

[Vidya Sagar]

Hi Alexander,
Thanks for the patch, but, we already have a patch for it here

https://patchwork.kernel.org/project/linux-pci/patch/20220913101237.4337-1-vidyas@nvidia.com/

and discussion is going on there.

Thanks,
Vidya Sagar

On 11/1/2022 1:48 PM, Alexander Stein wrote:
> External email: Use caution opening links or attachments
> 
> 
> Commit 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
> changed the severity from info to error. If no device is attached this
> error always is recorded which is not an error in this case.
> 
> Fixes: 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>   drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 9e4d96e5a3f5a..432aead68d1fd 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -448,7 +448,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>          }
> 
>          if (retries >= LINK_WAIT_MAX_RETRIES) {
> -               dev_err(pci->dev, "Phy link never came up\n");
> +               dev_info(pci->dev, "Phy link never came up\n");
>                  return -ETIMEDOUT;
>          }
> 
> --
> 2.34.1
> 

Re: Re: [PATCH 1/1] PCI: dwc: reduce log severity level if no link came up

[Alexander Stein]

Hi Vidya,

Am Dienstag, 1. November 2022, 09:27:50 CET schrieb Vidya Sagar:
> Hi Alexander,
> Thanks for the patch, but, we already have a patch for it here
> 
> https://patchwork.kernel.org/project/linux-pci/patch/20220913101237.4337-1-v
> idyas@nvidia.com/
> 
> and discussion is going on there.

Ah, I wasn't aware of that. Thanks for the link and sorry for the noise.

Thanks,
Alexander

> Thanks,
> Vidya Sagar
> 
> On 11/1/2022 1:48 PM, Alexander Stein wrote:
> > External email: Use caution opening links or attachments
> > 
> > 
> > Commit 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
> > changed the severity from info to error. If no device is attached this
> > error always is recorded which is not an error in this case.
> > 
> > Fixes: 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >   drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c
> > b/drivers/pci/controller/dwc/pcie-designware.c index
> > 9e4d96e5a3f5a..432aead68d1fd 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -448,7 +448,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > 
> >          }
> >          
> >          if (retries >= LINK_WAIT_MAX_RETRIES) {
> > 
> > -               dev_err(pci->dev, "Phy link never came up\n");
> > +               dev_info(pci->dev, "Phy link never came up\n");
> > 
> >                  return -ETIMEDOUT;
> >          
> >          }
> > 
> > --
> > 2.34.1