From: Arnd Bergmann <arnd@arndb.de>
To: Ley Foon Tan <lftan@altera.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-pci@vger.kernel.org, lftan.linux@gmail.com
Subject: Re: [PATCH 1/2] nios2: Add architectural support for PCIe
Date: Tue, 22 Sep 2015 10:18:58 +0200 [thread overview]
Message-ID: <65590637.5YmBIDOvTf@wuerfel> (raw)
In-Reply-To: <1442906367-10935-2-git-send-email-lftan@altera.com>
On Tuesday 22 September 2015 15:19:26 Ley Foon Tan wrote:
> +
> +config PCI_SYSCALL
> + def_bool PCI
IIRC, PCI_SYSCALL is deprecated and you should just leave that
turned off.
In any case, you enable the syscalls here but don't assign a
system call number, so that is rather pointless. I
I might be missing something though. Bjorn?
> @@ -14,7 +14,7 @@
> #include <linux/types.h>
> #include <asm/pgtable-bits.h>
>
> -/* PCI is not supported in nios2, set this to 0. */
> +/* PCI I/O space is not supported, set this to 0. */
> #define IO_SPACE_LIMIT 0
>
> #define readb_relaxed(addr) readb(addr)
It might be useful to enable this, just in case someone connects
a PCI host bridge that does support I/O space.
Which host bridge do you use? Are you sure there is no I/O space?
Most of them use a set of translation windows to set up a mapping
between bus address (memory, config and io space) and physical
(mmio) space.
> diff --git a/arch/nios2/include/asm/pci.h b/arch/nios2/include/asm/pci.h
> new file mode 100644
> index 0000000..f2cba05
> --- /dev/null
> +++ b/arch/nios2/include/asm/pci.h
What happens if you use the asm-generic header? If there is something
missing in it, we can try to get it to do the right things.
Arnd
next prev parent reply other threads:[~2015-09-22 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 7:19 [PATCH 0/2] Add PCI support on nios2 architecture Ley Foon Tan
2015-09-22 7:19 ` [PATCH 1/2] nios2: Add architectural support for PCIe Ley Foon Tan
2015-09-22 8:18 ` Arnd Bergmann [this message]
2015-09-22 10:53 ` Ley Foon Tan
2015-09-22 11:42 ` Arnd Bergmann
2015-09-29 3:12 ` Ley Foon Tan
2015-09-29 7:37 ` Arnd Bergmann
2015-09-29 10:00 ` Ley Foon Tan
2015-09-22 7:19 ` [PATCH 2/2] PCI: Build setup-irq.o for nios2 Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65590637.5YmBIDOvTf@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=lftan.linux@gmail.com \
--cc=lftan@altera.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox