Re: [RFC 4/6] drm/xe/vrsr: Refactor d3cold.allowed to a enum

["Poosa, Karthik" <karthik.poosa@intel.com>]

On 10-03-2025 22:58, Rodrigo Vivi wrote:
> On Mon, Feb 24, 2025 at 10:18:47PM +0530, Anshuman Gupta wrote:
>> Add xe_d3_state enum to add support for VRAM Self Refresh
>> d3cold state.
>>
>> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_device_types.h | 5 +++--
>>   drivers/gpu/drm/xe/xe_pm.c           | 6 +++---
>>   drivers/gpu/drm/xe/xe_pm.h           | 6 ++++++
>>   3 files changed, 12 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
>> index da7946b75cd5..937461939ecc 100644
>> --- a/drivers/gpu/drm/xe/xe_device_types.h
>> +++ b/drivers/gpu/drm/xe/xe_device_types.h
>> @@ -19,6 +19,7 @@
>>   #include "xe_memirq_types.h"
>>   #include "xe_oa_types.h"
>>   #include "xe_platform_types.h"
>> +#include "xe_pm.h"
>>   #include "xe_pmu_types.h"
>>   #include "xe_pt_types.h"
>>   #include "xe_sriov_types.h"
>> @@ -488,8 +489,8 @@ struct xe_device {
>>   		/** @d3cold.capable: Indicates if root port is d3cold capable */
>>   		bool capable;
>>   
>> -		/** @d3cold.allowed: Indicates if d3cold is a valid device state */
>> -		bool allowed;
>> +		/** @d3cold.allowed: Indicates d3cold target state */
>> +		enum xe_d3_state allowed;
> let's also rename the variable name to 'target_state'
>
> or xe->d3cold.allowed = XE_D3HOT //becomes strange
>
> xe->d3.target_state = XE_D3HOT sounds better imho
>
>>   
>>   		/** @d3cold.vrsr_capable: Indicates if d3cold VRAM Self Refresh is supported */
>>   		bool vrsr_capable;
>> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
>> index 32583651988f..81e67b5693dc 100644
>> --- a/drivers/gpu/drm/xe/xe_pm.c
>> +++ b/drivers/gpu/drm/xe/xe_pm.c
>> @@ -859,7 +859,7 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
>>   	int i;
>>   
>>   	if (!xe->d3cold.capable) {
>> -		xe->d3cold.allowed = false;
>> +		xe->d3cold.allowed = XE_D3HOT;
>>   		return;
>>   	}
>>   
>> @@ -874,9 +874,9 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
>>   	mutex_lock(&xe->d3cold.lock);
>>   
>>   	if (total_vram_used_mb < xe->d3cold.vram_threshold)
>> -		xe->d3cold.allowed = true;
>> +		xe->d3cold.allowed = XE_D3COLD_OFF;
>>   	else
>> -		xe->d3cold.allowed = false;
>> +		xe->d3cold.allowed = XE_D3HOT;
>>   
>>   	mutex_unlock(&xe->d3cold.lock);
>>   }
>> diff --git a/drivers/gpu/drm/xe/xe_pm.h b/drivers/gpu/drm/xe/xe_pm.h
>> index c9f176912b46..b7b74757ce21 100644
>> --- a/drivers/gpu/drm/xe/xe_pm.h
>> +++ b/drivers/gpu/drm/xe/xe_pm.h
>> @@ -12,6 +12,12 @@
>>   
>>   struct xe_device;
>>   
>> +enum xe_d3_state {
>> +	XE_D3HOT = 0,
>> +	XE_D3COLD_OFF,
>> +	XE_D3COLD_VRSR,
>> +};
Could you please reorder the enum based on the level of power 
consumption as shown below ?

+enum xe_d3_state {
+    XE_D3HOT = 0,
+    XE_D3COLD_VRSR,
+    XE_D3COLD_OFF,
+};

>> +
>>   int xe_pm_suspend(struct xe_device *xe);
>>   int xe_pm_resume(struct xe_device *xe);
>>   
>> -- 
>> 2.34.1
>>