From: Thomas Gleixner <tglx@linutronix.de>
To: Marek Vasut <marek.vasut@mailbox.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
linux-pci@vger.kernel.org
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Marc Zyngier" <maz@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] [RFC] genirq/cpuhotplug, PCI/rcar-host: Silence set affinity failed warning
Date: Wed, 10 Jul 2024 18:11:35 +0200 [thread overview]
Message-ID: <8734ohw7k8.ffs@tglx> (raw)
In-Reply-To: <875xtewkji.ffs@tglx>
On Tue, Jul 09 2024 at 19:18, Thomas Gleixner wrote:
> On Mon, Jul 08 2024 at 13:55, Marek Vasut wrote:
>> On 7/7/24 8:47 PM, Thomas Gleixner wrote:
>>> Why does the irq_chip in question have an irq_set_affinity() callback in
>>> the first place?
>> I believe originally (at least that's what's being discussed in the
>> linked threads) it was because the irqchip code didn't check whether
>> .irq_set_affinity was not NULL at all, so if it was missing, there would
>> be NULL pointer dereference.
>>
>> Now this is checked and irq_do_set_affinity() returns -EINVAL, which
>> triggers the warning that is being silenced by this patch.
>>
>> If you think this is better, I can:
>> - Tweak the cpuhotplug.c code to do some
>> if (chip && !chip->irq_set_affinity) return false;
>
> It does already:
>
> migrate_one_irq()
> if (chip && !chip->irq_set_affinity)
> return false;
>
> Right at the top.
if (!chip || !chip->irq_set_affinity) {
Obviously :)
prev parent reply other threads:[~2024-07-10 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 13:27 [PATCH] [RFC] genirq/cpuhotplug, PCI/rcar-host: Silence set affinity failed warning Marek Vasut
2024-07-07 18:47 ` Thomas Gleixner
2024-07-08 11:55 ` Marek Vasut
2024-07-09 17:18 ` Thomas Gleixner
2024-07-10 16:11 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ohw7k8.ffs@tglx \
--to=tglx@linutronix.de \
--cc=Jisheng.Zhang@synaptics.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marek.vasut@mailbox.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox