Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, linux-pci@vger.kernel.org
Cc: "Marek Vasut" <marek.vasut+renesas@mailbox.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
	"Jon Hunter" <jonathanh@nvidia.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] [RFC] genirq/cpuhotplug, PCI/rcar-host: Silence set affinity failed warning
Date: Sun, 07 Jul 2024 20:47:39 +0200	[thread overview]
Message-ID: <87h6d1vy2c.ffs@tglx> (raw)
In-Reply-To: <20240706132758.53298-1-marek.vasut+renesas@mailbox.org>

Marek!

On Sat, Jul 06 2024 at 15:27, Marek Vasut wrote:

> This is an RFC patch, I am looking for input on the approach taken here.
> If the approach is sound, this patch would be split into proper patchset.
>
> Various PCIe controllers that mux MSIs onto single IRQ line produce these
> "IRQ%d: set affinity failed" warnings when entering suspend. This has been
> discussed before [1] [2] and an example test case is included at the end
> of this commit message.
>
> Attempt to silence the warning by returning specific error code -EOPNOTSUPP
> from the irqchip .irq_set_affinity callback, which skips printing the warning
> in cpuhotplug.c . The -EOPNOTSUPP was chosen because it indicates exactly what
> the problem is, it is not possible to set affinity of each MSI IRQ line to a
> specific CPU due to hardware limitation.

Why does the irq_chip in question have an irq_set_affinity() callback in
the first place?

Thanks,

        tglx

  reply	other threads:[~2024-07-07 18:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-06 13:27 [PATCH] [RFC] genirq/cpuhotplug, PCI/rcar-host: Silence set affinity failed warning Marek Vasut
2024-07-07 18:47 ` Thomas Gleixner [this message]
2024-07-08 11:55   ` Marek Vasut
2024-07-09 17:18     ` Thomas Gleixner
2024-07-10 16:11       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6d1vy2c.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=Jisheng.Zhang@synaptics.com \
    --cc=bhelgaas@google.com \
    --cc=jonathanh@nvidia.com \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=maz@kernel.org \
    --cc=robh@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox