From: Karolina Stolarek <karolina.stolarek@oracle.com>
To: Jon Pan-Doh <pandoh@google.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Martin Petersen" <martin.petersen@oracle.com>,
"Ben Fuller" <ben.fuller@oracle.com>,
"Drew Walton" <drewwalton@microsoft.com>,
"Anil Agrawal" <anilagrawal@meta.com>,
"Tony Luck" <tony.luck@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sathyanarayanan Kuppuswamy"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Terry Bowman" <Terry.bowman@amd.com>
Subject: Re: [PATCH v4 3/7] PCI/AER: Move AER stat collection out of __aer_print_error()
Date: Thu, 20 Mar 2025 15:59:22 +0100 [thread overview]
Message-ID: <93a5832f-3e64-40ce-b089-b94181e8ba09@oracle.com> (raw)
In-Reply-To: <20250320082057.622983-4-pandoh@google.com>
On 20/03/2025 09:20, Jon Pan-Doh wrote:
> Decouple stat collection from internal AER print functions. Prerequisite
> to add ratelimits to logs while leaving stats unaffected. Also simplifies
> control flow as stats collection is no longer buried in nested functions.
>
> AERs from ghes or cxl drivers are a minor exception. Stat collection occurs
> in pci_print_aer(), an external interface, as that is where aer_err_info
> is populated.
Hopefully, I'll get my patch in sooner than later, and the second
paragraph (and the related changes) will go away.
As for the first one, I'd restructure it to chain all the sentences
together. I'm thinking about something like this:
"
Decouple stat collection from internal AER print functions, so the
ratelimit does not impact the error counters. The stats collection is no
longer buried in nested functions, simplifying the function flow.
"
All the best,
Karolina
next prev parent reply other threads:[~2025-03-20 14:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 8:20 [PATCH v4 0/7] Rate limit AER logs Jon Pan-Doh
2025-03-20 8:20 ` [PATCH v4 1/7] PCI/AER: Check log level once and propagate down Jon Pan-Doh
2025-03-20 8:20 ` [PATCH v4 2/7] PCI/AER: Make all pci_print_aer() log levels depend on error type Jon Pan-Doh
2025-03-20 8:20 ` [PATCH v4 3/7] PCI/AER: Move AER stat collection out of __aer_print_error() Jon Pan-Doh
2025-03-20 14:59 ` Karolina Stolarek [this message]
2025-03-20 19:07 ` Jon Pan-Doh
2025-03-20 8:20 ` [PATCH v4 4/7] PCI/AER: Rename struct aer_stats to aer_report Jon Pan-Doh
2025-03-20 17:42 ` Sathyanarayanan Kuppuswamy
2025-03-20 19:53 ` Jon Pan-Doh
2025-03-21 13:38 ` Karolina Stolarek
2025-03-20 8:20 ` [PATCH v4 5/7] PCI/AER: Introduce ratelimit for error logs Jon Pan-Doh
2025-03-20 14:56 ` Karolina Stolarek
2025-03-20 17:51 ` Bjorn Helgaas
2025-03-20 19:53 ` Jon Pan-Doh
2025-03-20 20:29 ` Bjorn Helgaas
2025-03-21 1:58 ` Jon Pan-Doh
2025-03-20 19:37 ` Jon Pan-Doh
2025-03-21 1:00 ` Sathyanarayanan Kuppuswamy
2025-03-21 19:24 ` Jon Pan-Doh
2025-03-21 21:47 ` Sathyanarayanan Kuppuswamy
2025-03-21 21:59 ` Bjorn Helgaas
2025-03-21 22:11 ` Jon Pan-Doh
2025-03-20 8:20 ` [PATCH v4 6/7] PCI/AER: Add ratelimits to PCI AER Documentation Jon Pan-Doh
2025-03-20 14:57 ` Karolina Stolarek
2025-03-21 1:00 ` Sathyanarayanan Kuppuswamy
2025-03-20 8:20 ` [PATCH v4 7/7] PCI/AER: Add sysfs attributes for log ratelimits Jon Pan-Doh
2025-03-20 14:58 ` Karolina Stolarek
2025-03-20 19:36 ` Jon Pan-Doh
2025-03-21 1:02 ` Sathyanarayanan Kuppuswamy
2025-03-21 1:55 ` Jon Pan-Doh
2025-03-20 14:34 ` [PATCH v4 0/7] Rate limit AER logs Christoph Hellwig
2025-03-20 18:45 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a5832f-3e64-40ce-b089-b94181e8ba09@oracle.com \
--to=karolina.stolarek@oracle.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Terry.bowman@amd.com \
--cc=anilagrawal@meta.com \
--cc=ben.fuller@oracle.com \
--cc=bhelgaas@google.com \
--cc=drewwalton@microsoft.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=martin.petersen@oracle.com \
--cc=pandoh@google.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox