From: Reinette Chatre <reinette.chatre@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: <bhelgaas@google.com>, <nathan@kernel.org>,
<ndesaulniers@google.com>, <trix@redhat.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<llvm@lists.linux.dev>, <tglx@linutronix.de>,
<kevin.tian@intel.com>, <darwi@linutronix.de>
Subject: Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled
Date: Tue, 14 Feb 2023 14:44:11 -0800 [thread overview]
Message-ID: <9b5972a2-63a9-6e2e-78aa-55ac112ef9ad@intel.com> (raw)
In-Reply-To: <20230214222400.GA3089902@bhelgaas>
Hi Bjorn,
On 2/14/2023 2:24 PM, Bjorn Helgaas wrote:
> I think this should have a "Fixes:" tag to connect it with the commit
> that added pci_msix_alloc_irq_at() and pci_msix_free_irq().
>
Thank you. I was not sure if a Fixes tag was needed since it does not
fix an existing issue but instead prevents a future issue.
> Looks like 34026364df8e ("PCI/MSI: Provide post-enable dynamic
> allocation interfaces for MSI-X").
>
Correct.
> Thomas merged 34026364df8e, so it would be best if he took the fixup
> as well.
Thomas did pick this up in tip's irq/urgent branch. While doing so he
added the Fixes tag that you proposed and also improved the subject.
Thank you very much
Reinette
next prev parent reply other threads:[~2023-02-14 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 21:49 [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled Reinette Chatre
2023-02-10 5:12 ` Tian, Kevin
2023-02-10 20:45 ` ALOK TIWARI
2023-02-10 21:12 ` Reinette Chatre
2023-02-11 5:05 ` [External] : " ALOK TIWARI
2023-02-13 18:46 ` Thomas Gleixner
2023-02-14 22:24 ` Bjorn Helgaas
2023-02-14 22:44 ` Reinette Chatre [this message]
2023-02-14 23:02 ` Thomas Gleixner
2023-02-14 23:14 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5972a2-63a9-6e2e-78aa-55ac112ef9ad@intel.com \
--to=reinette.chatre@intel.com \
--cc=bhelgaas@google.com \
--cc=darwi@linutronix.de \
--cc=helgaas@kernel.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox