Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>, <bhelgaas@google.com>,
	<nathan@kernel.org>, <ndesaulniers@google.com>, <trix@redhat.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<llvm@lists.linux.dev>, <tglx@linutronix.de>,
	<kevin.tian@intel.com>, <darwi@linutronix.de>
Subject: Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled
Date: Fri, 10 Feb 2023 13:12:43 -0800	[thread overview]
Message-ID: <af294def-fff7-469c-b8c6-a245ba641c2c@intel.com> (raw)
In-Reply-To: <333dee5b-6710-998c-bf3f-2cb1d676a7da@oracle.com>

Hi Alok,

On 2/10/2023 12:45 PM, ALOK TIWARI wrote:
> shall we need to define this function under -> #ifndef CONFIG_PCI_MSI
> 
> #ifndef CONFIG_PCI_MSI
> 
> +static inline struct msi_map
> +pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index,
> +              const struct irq_affinity_desc *affdesc)
> +{
> +    struct msi_map map = { .index = -ENOSYS };
> +
> +    return map;
> +}
> +
> +static inline void pci_msix_free_irq(struct pci_dev *pdev, struct msi_map map)
> +{
> +}
> +#endif

No need. include/linux/pci.h already has those definitions.

include/linux/pci.h already has:

#ifdef CONFIG_PCI_MSI

...

#else

... 
/*  new function definitions will be inserted here */
...

#endif


Reinette

  reply	other threads:[~2023-02-10 21:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 21:49 [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled Reinette Chatre
2023-02-10  5:12 ` Tian, Kevin
2023-02-10 20:45 ` ALOK TIWARI
2023-02-10 21:12   ` Reinette Chatre [this message]
2023-02-11  5:05     ` [External] : " ALOK TIWARI
2023-02-13 18:46       ` Thomas Gleixner
2023-02-14 22:24 ` Bjorn Helgaas
2023-02-14 22:44   ` Reinette Chatre
2023-02-14 23:02   ` Thomas Gleixner
2023-02-14 23:14     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af294def-fff7-469c-b8c6-a245ba641c2c@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=bhelgaas@google.com \
    --cc=darwi@linutronix.de \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox