From: Michael Schaller <michael@5challer.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
macro@orcam.me.uk, ajayagarwal@google.com,
sathyanarayanan.kuppuswamy@linux.intel.com,
gregkh@linuxfoundation.org, hkallweit1@gmail.com,
michael.a.bottini@linux.intel.com, johan+linaro@kernel.org
Subject: Re: [Regression] [PCI/ASPM] [ASUS PN51] Reboot on resume attempt (bisect done; commit found)
Date: Wed, 10 Jan 2024 13:39:56 +0100 [thread overview]
Message-ID: <9f0f9de4-2d34-4ff3-a901-c3e4b48e4ab0@5challer.de> (raw)
In-Reply-To: <CAAd53p5Eg4J9bRtAHY+JZ11cy1D0TnKmAaLfzcRJzw15VRBxXw@mail.gmail.com>
On 10.01.24 04:43, Kai-Heng Feng wrote:
> On Fri, Jan 5, 2024 at 11:51 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> On Fri, Jan 05, 2024 at 12:18:32PM +0100, Michael Schaller wrote:
>>> On 05.01.24 04:25, Kai-Heng Feng wrote:
>>>> Just wondering, does `echo 0 > /sys/power/pm_asysnc` help?
>>>
>>> Yes, `echo 0 | sudo tee /sys/power/pm_async` does indeed also result in a
>>> working resume. I've tested this on kernel 6.6.9 (which still has commit
>>> 08d0cc5f3426). I've also attached the relevant dmesg output of the
>>> suspend/resume cycle in case this helps.
>>
>> Thanks for testing that!
>>
>>> Furthermore does this mean that commit 08d0cc5f3426 isn't at fault but
>>> rather that we are dealing with a timing issue?
>>
>> PCI does have a few software timing requirements, mostly related to
>> reset and power state (D0/D3cold). ASPM has some timing parameters,
>> too, but I think they're all requirements on the hardware, not on
>> software.
>>
>> Adding an arbitrary delay anywhere shouldn't break anything, and other
>> than those few required situations, it shouldn't fix anything either.
>
> At least it means 8d0cc5f3426 isn't the culprit?
>
> Michael, does the issue happen when iwlwifi module is not loaded? It
> can be related to iwlwifi firmware.
>
> Kai-Heng
>
The issue still happens if the iwlwifi module has been blacklisted and
after a reboot. This was again with vanilla kernel 6.6.9 and I've
confirmed via dmesg that iwlwifi wasn't loaded.
I've also checked if there is a newer firmware but Ubuntu 23.10 is
already using the newest firmware available from
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/log/iwlwifi-8265-36.ucode
(version 36.ca7b901d.0 according to dmesg).
Michael
>>
>> Bjorn
next prev parent reply other threads:[~2024-01-10 12:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 18:29 [Regression] [PCI/ASPM] [ASUS PN51] Reboot on resume attempt (bisect done; commit found) Michael Schaller
2023-12-29 0:26 ` Bjorn Helgaas
2023-12-29 10:31 ` Michael Schaller
2024-01-01 18:13 ` Bjorn Helgaas
2024-01-01 18:57 ` Michael Schaller
2024-01-01 22:15 ` Bjorn Helgaas
2024-01-02 13:50 ` Michael Schaller
2024-01-03 8:21 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-05 3:25 ` Kai-Heng Feng
2024-01-05 11:18 ` Michael Schaller
2024-01-05 15:51 ` Bjorn Helgaas
2024-01-10 3:43 ` Kai-Heng Feng
2024-01-10 12:39 ` Michael Schaller [this message]
2024-03-07 6:51 ` Kai-Heng Feng
2024-03-08 15:49 ` michael
2024-03-08 16:40 ` Bjorn Helgaas
2024-01-03 15:41 ` Ilpo Järvinen
2024-01-05 3:14 ` Kai-Heng Feng
2024-01-05 10:29 ` Ilpo Järvinen
2024-01-02 23:25 ` [PATCH] Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()" Bjorn Helgaas
2024-01-02 23:33 ` Kuppuswamy Sathyanarayanan
2024-01-03 0:12 ` Bjorn Helgaas
2024-01-08 8:39 ` Johan Hovold
2024-01-22 10:53 ` PCI/ASPM locking regression in 6.7-final (was: Re: [PATCH] Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()") Johan Hovold
2024-01-22 18:26 ` Bjorn Helgaas
2024-01-23 17:25 ` Johan Hovold
2024-01-23 22:36 ` Bjorn Helgaas
2024-01-24 8:16 ` Johan Hovold
2024-01-30 10:07 ` Johan Hovold
2024-02-09 12:45 ` PCI/ASPM locking regression in 6.7-final Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f0f9de4-2d34-4ff3-a901-c3e4b48e4ab0@5challer.de \
--to=michael@5challer.de \
--cc=ajayagarwal@google.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=michael.a.bottini@linux.intel.com \
--cc=regressions@lists.linux.dev \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox