Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Jonathan Woithe <jwoithe@just42.net>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] PCI: Solve two bridge window sizing issues
Date: Thu, 11 Jan 2024 18:30:18 +1030	[thread overview]
Message-ID: <ZZ+gEmxI/TxdbmyQ@marvin.atrad.com.au> (raw)
In-Reply-To: <ZZaiLOR4aO84CG2S@marvin.atrad.com.au>

On Thu, Jan 04, 2024 at 10:48:53PM +1030, Jonathan Woithe wrote:
> On Thu, Jan 04, 2024 at 01:12:10PM +0100, Igor Mammedov wrote:
> > On Thu, 28 Dec 2023 18:57:00 +0200
> > Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> > 
> > > Hi all,
> > > 
> > > Here's a series that contains two fixes to PCI bridge window sizing
> > > algorithm. Together, they should enable remove & rescan cycle to work
> > > for a PCI bus that has PCI devices with optional resources and/or
> > > disparity in BAR sizes.
> > > 
> > > For the second fix, I chose to expose find_empty_resource_slot() from
> > > kernel/resource.c because it should increase accuracy of the cannot-fit
> > > decision (currently that function is called find_resource()). In order
> > > to do that sensibly, a few improvements seemed in order to make its
> > > interface and name of the function sane before exposing it. Thus, the
> > > few extra patches on resource side.
> > > 
> > > Unfortunately I don't have a reason to suspect these would help with
> > > the issues related to the currently ongoing resource regression
> > > thread [1].
> > 
> > Jonathan,
> > can you test this series on affected machine with broken kernel to see if
> > it's of any help in your case?
> 
> Certainly, but it will have to wait until next Thursday (11 Jan 2024).  I'm
> still on leave this week, and when at work I only have physical access to
> the machine concerned on Thursdays at present.
> 
> Which kernel would you prefer I apply the series to?

I was very short of time today but I did apply the above series to the
5.15.y branch (since I had this source available), resulting in version
5.15.141+.  Unfortunately, in the rush I forgot to do a clean after the
bisect reset, so the resulting kernel was not correctly built.  It booted
but thought it was a different version and therefore none of the modules
could be found.  As a result, the test is invalid.

I will try again in a week when I next have physical access to the system. 
Apologies for the delay.  In the meantime, if there's a specific kernel I
should apply the patch series against please let me know.  As I understand
it, you want it applied to one of the kernels which failed, making 5.15.y
(for y < 145) a reasonable choice.

Regards
  jonathan

  reply	other threads:[~2024-01-11  8:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 16:57 [PATCH v2 0/7] PCI: Solve two bridge window sizing issues Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 1/7] PCI: Fix resource double counting on remove & rescan Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 2/7] resource: Rename find_resource() to find_empty_resource_slot() Ilpo Järvinen
2024-05-03 20:49   ` Bjorn Helgaas
2024-05-06 12:30     ` Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 3/7] resource: Document find_empty_resource_slot() and resource_constraint Ilpo Järvinen
2024-05-03 20:51   ` Bjorn Helgaas
2023-12-28 16:57 ` [PATCH v2 4/7] resource: Use typedef for alignf callback Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 5/7] resource: Handle simple alignment inside __find_empty_resource_slot() Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 6/7] resource: Export find_empty_resource_slot() Ilpo Järvinen
2023-12-28 16:57 ` [PATCH v2 7/7] PCI: Relax bridge window tail sizing rules Ilpo Järvinen
2024-05-03 20:43   ` Bjorn Helgaas
2024-05-06 11:55     ` Ilpo Järvinen
2023-12-29 12:24 ` [PATCH v2 0/7] PCI: Solve two bridge window sizing issues Mika Westerberg
2024-01-04 12:12 ` Igor Mammedov
2024-01-04 12:18   ` Jonathan Woithe
2024-01-11  8:00     ` Jonathan Woithe [this message]
2024-01-18  6:48       ` Jonathan Woithe
2024-01-18  9:27         ` Ilpo Järvinen
2024-01-21 12:54         ` Andy Shevchenko
2024-01-21 22:20           ` Jonathan Woithe
2024-01-22 12:37             ` Ilpo Järvinen
2024-01-22 13:45               ` Igor Mammedov
2024-01-31 22:48                 ` Jonathan Woithe
2024-02-01 14:47                   ` Ilpo Järvinen
2024-03-15 10:33 ` Ilpo Järvinen
2024-03-15 14:39   ` Andy Shevchenko
2024-04-09 14:53 ` Jonathan Cameron
2024-04-11 10:41   ` Ilpo Järvinen
2024-04-11 11:16     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZ+gEmxI/TxdbmyQ@marvin.atrad.com.au \
    --to=jwoithe@just42.net \
    --cc=andriy.shevchenko@intel.com \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=imammedo@redhat.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox