答复: [外部邮件] Re: [PATCH] PCI/ACPI: Check the found handle in acpi_get_rc_resources()

["Li,Rongqing" <lirongqing@baidu.com>]

> -----邮件原件-----
> 发件人: sashiko-bot@kernel.org <sashiko-bot@kernel.org>
> 发送时间: 2026年11月10日 13:41
> 收件人: Li,Rongqing <lirongqing@baidu.com>; linux-pci@vger.kernel.org
> 主题: [外部邮件] Re: [PATCH] PCI/ACPI: Check the found handle in
> acpi_get_rc_resources()
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue to
> consider:
> - [Low] PCI/ACPI: missing Fixes trailer for acpi_get_rc_resources() fix
> --
> 
> commit 2dd263c8741dc2f24a59dc48d0def98c31872ce2
> Author: Li RongQing <lirongqing@baidu.com>
> 
> > PCI/ACPI: Check the found handle in acpi_get_rc_resources()
> >
> > acpi_get_devices() returns AE_OK even when the namespace walk finishes
> > without a match, in which case the return_value argument is not written.
> > The caller passes an uninitialized acpi_handle and hands it to
> > acpi_fetch_acpi_dev(), which dereferences it as an ACPI node.
> >
> > Initialize the handle and reject a missing match.
> >
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
> 
> [Severity: Low]
> Since this fixes an uninitialized handle dereference in
> acpi_get_rc_resources() when acpi_get_devices() completes without a match,
> please add a Fixes tag:
> 
>   Fixes: 169de969c018 ("PCI/ACPI: Provide acpi_get_rc_resources() for ARM64
> platform")
> 

I think this issue has limited impact, so I didn't add a Fixes tag. Please, maintainer, check whether a Fixes tag is needed when merging.

[Li,Rongqing] 

> --
> Sashiko AI
> review · https://sashiko.dev/#/patchset/20261110053423.2517-1-lirongqing
> @baidu.com?part=1