Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: lirongqing <lirongqing@baidu.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/ACPI: Check the found handle in acpi_get_rc_resources()
Date: Tue, 10 Nov 2026 05:41:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-206326@kernel.org> (raw)
In-Reply-To: <20261110053423.2517-1-lirongqing@baidu.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI/ACPI: missing Fixes trailer for acpi_get_rc_resources() fix
--

commit 2dd263c8741dc2f24a59dc48d0def98c31872ce2
Author: Li RongQing <lirongqing@baidu.com>

> PCI/ACPI: Check the found handle in acpi_get_rc_resources()
>
> acpi_get_devices() returns AE_OK even when the namespace walk finishes
> without a match, in which case the return_value argument is not written.
> The caller passes an uninitialized acpi_handle and hands it to
> acpi_fetch_acpi_dev(), which dereferences it as an ACPI node.
>
> Initialize the handle and reject a missing match.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

[Severity: Low]
Since this fixes an uninitialized handle dereference in
acpi_get_rc_resources() when acpi_get_devices() completes without a
match, please add a Fixes tag:

  Fixes: 169de969c018 ("PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110053423.2517-1-lirongqing@baidu.com?part=1

  reply	other threads:[~2026-11-10  5:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  5:34 [PATCH] PCI/ACPI: Check the found handle in acpi_get_rc_resources() lirongqing
2026-11-10  5:41 ` sashiko-bot [this message]
2026-11-10  8:11   ` 答复: [外部邮件] " Li,Rongqing
2026-11-10 11:33 ` Rafael J. Wysocki (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-206326@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox