Re: [PATCH v7 1/2] PCI: Introduce named defines for pci rom

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Thu, 11 Dec 2025, Guixin Liu wrote:

> This is a preparation patch for the next fix patch.
> Convert some magic numbers to named defines.
> 
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
>  drivers/pci/rom.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
> index e18d3a4383ba..3e00611fa76b 100644
> --- a/drivers/pci/rom.c
> +++ b/drivers/pci/rom.c
> @@ -9,9 +9,20 @@
>  #include <linux/export.h>
>  #include <linux/pci.h>
>  #include <linux/slab.h>
> +#include <linux/bits.h>

Includes should always be ordered alphabetically when they already are so.

Even in to other cases it's better try to place them close to the 
right place wrt. other headers when it comes to alphabetical order, even 
if some pre-existing headers would violate it still.

>  #include "pci.h"
>  
> +#define PCI_ROM_HEADER_SIZE			0x1A
> +#define PCI_ROM_POINTER_TO_DATA_STRUCT		0x18
> +#define PCI_ROM_LAST_IMAGE_INDICATOR		0x15
> +#define PCI_ROM_LAST_IMAGE_INDICATOR_BIT	BIT(7)
> +#define PCI_ROM_IMAGE_LEN			0x10
> +#define PCI_ROM_IMAGE_LEN_UNIT_SZ_512		512
> +#define PCI_ROM_IMAGE_SIGNATURE			0xAA55
> +#define PCI_ROM_DATA_STRUCT_SIGNATURE		0x52494350
> +#define PCI_ROM_DATA_STRUCT_LEN			0x0A
> +
>  /**
>   * pci_enable_rom - enable ROM decoding for a PCI device
>   * @pdev: PCI device to enable

You should convert the literals in the code too in this patch already.

I know it's a bit work to rebase the second patch on top of this, but you 
actually don't need to do it that way (you can just make changes to this 
patch and then use git diff to produce the very same end result so you 
don't need to resolve any rebase conflicts).

-- 
 i.