From: Lukas Wunner <lukas@wunner.de>
To: "Jozef Matejcik (Nokia)" <jozef.matejcik@nokia.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: pci_probe called concurrently in machine with 2 identical PCI devices causing race condition
Date: Thu, 26 Jun 2025 14:26:56 +0200 [thread overview]
Message-ID: <aF08kFNy8qrI8LvD@wunner.de> (raw)
In-Reply-To: <AS4PR07MB8508CA1516E932B243AC5139937AA@AS4PR07MB8508.eurprd07.prod.outlook.com>
On Thu, Jun 26, 2025 at 12:20:48PM +0000, Jozef Matejcik (Nokia) wrote:
> The driver keeps internal global array of initialized devices and their
> count.
[...]
> I know this can be fixed in the driver by proper locking
Right.
> However, I think this can happen in any machine with 2 identical
> PCI devices, because as far as I know, existing PCI drivers usually
> do not assume that probe function can be called from multiple threads.
That can happen all the time and it would be a bug in the driver
if it caused issues.
Thanks,
Lukas
next prev parent reply other threads:[~2025-06-26 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 10:14 pci_probe called concurrently in machine with 2 identical PCI devices causing race condition Jozef Matejcik (Nokia)
2025-06-26 12:08 ` Lukas Wunner
2025-06-26 12:20 ` Jozef Matejcik (Nokia)
2025-06-26 12:26 ` Lukas Wunner [this message]
2025-06-26 15:41 ` Keith Busch
2025-06-26 18:16 ` Jozef Matejcik (Nokia)
2025-06-26 22:37 ` Keith Busch
2025-07-04 8:03 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF08kFNy8qrI8LvD@wunner.de \
--to=lukas@wunner.de \
--cc=jozef.matejcik@nokia.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox