Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: "Jozef Matejcik (Nokia)" <jozef.matejcik@nokia.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: pci_probe called concurrently in machine with 2 identical PCI devices causing race condition
Date: Thu, 26 Jun 2025 09:41:58 -0600	[thread overview]
Message-ID: <aF1qRv0XlT4EDN-Y@kbusch-mbp> (raw)
In-Reply-To: <aF08kFNy8qrI8LvD@wunner.de>

On Thu, Jun 26, 2025 at 02:26:56PM +0200, Lukas Wunner wrote:
> On Thu, Jun 26, 2025 at 12:20:48PM +0000, Jozef Matejcik (Nokia) wrote:
> > However, I think this can happen in any machine with 2 identical
> > PCI devices, because as far as I know, existing PCI drivers usually
> > do not assume that probe function can be called from multiple threads.
> 
> That can happen all the time and it would be a bug in the driver
> if it caused issues.

Wait, is that true? I thought that would only happen if the driver
indicated probe_type PROBE_PREFER_ASYNCHRONOUS. The default appears to
still be the same as PROBE_FORCE_SYNCHRONOUS.

  reply	other threads:[~2025-06-26 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 10:14 pci_probe called concurrently in machine with 2 identical PCI devices causing race condition Jozef Matejcik (Nokia)
2025-06-26 12:08 ` Lukas Wunner
2025-06-26 12:20   ` Jozef Matejcik (Nokia)
2025-06-26 12:26     ` Lukas Wunner
2025-06-26 15:41       ` Keith Busch [this message]
2025-06-26 18:16         ` Jozef Matejcik (Nokia)
2025-06-26 22:37           ` Keith Busch
2025-07-04  8:03         ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aF1qRv0XlT4EDN-Y@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=jozef.matejcik@nokia.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox