From: Lukas Wunner <lukas@wunner.de>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Johannes Thumshirn <morbidrsa@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PCI: Initialize RCB from pci_configure_device
Date: Wed, 21 Jan 2026 18:41:19 +0100 [thread overview]
Message-ID: <aXEPv8BChwIhlZPa@wunner.de> (raw)
In-Reply-To: <20260121113544.4163457-2-haakon.bugge@oracle.com>
On Wed, Jan 21, 2026 at 12:35:40PM +0100, Håkon Bugge wrote:
> + if (pcie_cap_has_lnkctl(dev) &&
> + (pci_pcie_type(dev) != PCI_EXP_TYPE_ROOT_PORT) &&
> + !dev->is_virtfn && pcie_root_rcb_set(dev)) {
> + u16 lnkctl;
> +
> + pcie_capability_read_word(dev, PCI_EXP_LNKCTL, &lnkctl);
> + if (lnkctl & PCI_EXP_LNKCTL_RCB)
> + return;
> +
> + pcie_capability_write_word(dev, PCI_EXP_LNKCTL, lnkctl | PCI_EXP_LNKCTL_RCB);
You may want to use pcie_capability_set_word() for brevity.
Thanks,
Lukas
next prev parent reply other threads:[~2026-01-21 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 11:35 [PATCH v2 0/2] PCI: Init RCB from pci_configure_device and fix program_hpx_type2 Håkon Bugge
2026-01-21 11:35 ` [PATCH v2 1/2] PCI: Initialize RCB from pci_configure_device Håkon Bugge
2026-01-21 17:41 ` Lukas Wunner [this message]
2026-01-21 19:13 ` Haakon Bugge
2026-01-21 22:40 ` Bjorn Helgaas
2026-01-22 9:42 ` Haakon Bugge
2026-01-22 10:22 ` Bjorn Helgaas
2026-01-22 10:36 ` Bjorn Helgaas
2026-01-22 10:49 ` Haakon Bugge
2026-01-22 11:04 ` Bjorn Helgaas
2026-01-22 11:12 ` Haakon Bugge
2026-01-22 11:35 ` Niklas Schnelle
2026-01-22 13:25 ` Haakon Bugge
2026-01-21 11:35 ` [PATCH v2 2/2] PCI/ACPI: Confine program_hpx_type2 to the AER bits Håkon Bugge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXEPv8BChwIhlZPa@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=haakon.bugge@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox