Re: [PATCH v3 0/5] PCI/pwrctrl: tc9563: introduce support for embedded GPIO controller

[Alex Elder <elder@riscstar.com>]

On 9/4/26 12:15 PM, Lorenzo Bianconi wrote:
> This series is based on pwrctrl upstream branch.

I'm accustomed to a cover page that's a bit more informative
than this about the subject of the series overall.  Your use
of --base (to produce the "base-commit" tag below) duplicates
(more specifically) the above statement anyway.

How about just a little bit of context about how the TC9563
uses an embedded GPIO controller that we now wish to also
use in another driver.  So this series isolates the access
to that IP block in a separate driver that can safely share
access?

You might even highlight that the TC9563 is an SoC that
*contains* a PCIe switch, but also contains other components
(including an I2C interface and GPIO controller).

Aside from that, the series looks good to me.  You just need
approval from the devicetree maintainers.

					-Alex
  > ---
> Changes in v3:
> - Describe gpio-controller support in TC9563 binding instead of defining
>    a gpio child node.
> - Link to v2: https://lore.kernel.org/r/20260903-pci-tc9563-aux-v2-0-34c625b542c1@oss.qualcomm.com
> 
> Changes in v2:
> - Fix PCI_PWRCTRL_TC9563 Kconfig dependency
> - Move of_node refcounting management in tc9563_pwrctrl_adev_add().
> - Link to v1: https://lore.kernel.org/r/20260901-pci-tc9563-aux-v1-0-dd9b80738e70@oss.qualcomm.com
> 
> ---
> Alex Elder (1):
>        gpio: tc9563: Add support for the embedded GPIO controller
> 
> Lorenzo Bianconi (4):
>        dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller
>        PCI/pwrctrl: tc9563: Add GPIO auxiliary device support
>        PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API
>        arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller
> 
>   .../devicetree/bindings/pci/toshiba,tc9563.yaml    |  19 ++-
>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts       |   7 +-
>   drivers/gpio/Kconfig                               |  11 ++
>   drivers/gpio/Makefile                              |   1 +
>   drivers/gpio/gpio-tc9563.c                         |  99 +++++++++++++
>   drivers/pci/pwrctrl/Kconfig                        |   1 +
>   drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c           | 154 +++++++++++++++++++--
>   include/linux/soc/qcom/tc9563.h                    |  19 +++
>   8 files changed, 294 insertions(+), 17 deletions(-)
> ---
> base-commit: 028f86457e822ab9de5b0d6d23efddc1b8b54ae1
> change-id: 20260731-pci-tc9563-aux-66a29d438f60
> 
> Best regards,