[PATCH pciutils] ls-ecaps: Correct IDE link state reporting

[PATCH pciutils] ls-ecaps: Correct IDE link state reporting

[Alexey Kardashevskiy]

PCIe r6.0, sec 7.9.26.4.2 "Link IDE Stream Status Register defines"
the link state as:

0000b Insecure
0010b Secure

The same definition applies to selective streams as well.
The existing code wrongly assumes "secure" is 0001b, fix that for both
link and selective streams.

Fixes: 42fc4263ec0e ("ls-ecaps: Add decode support for IDE Extended Capability")
Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
---
 ls-ecaps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ls-ecaps.c b/ls-ecaps.c
index b40ba72..5c2724e 100644
--- a/ls-ecaps.c
+++ b/ls-ecaps.c
@@ -1512,7 +1512,7 @@ static void
 cap_ide(struct device *d, int where)
 {
     const char *hdr_enc_mode[] = { "no", "17:2", "25:2", "33:2", "41:2" };
-    const char *stream_state[] = { "insecure", "secure" };
+    const char *stream_state[] = { "insecure", "reserved", "secure" };
     const char *aggr[] = { "-", "=2", "=4", "=8" };
     u32 l, l2, linknum = 0, selnum = 0, addrnum, off, i, j;
     char buf1[16], buf2[16], offs[16];
-- 
2.41.0

Re: [PATCH pciutils] ls-ecaps: Correct IDE link state reporting

[Alexey Kardashevskiy]

I found more inconsistencies so v2 will come soon. Sorry for the noise. 
Thanks,


On 11/4/24 14:28, Alexey Kardashevskiy wrote:
> PCIe r6.0, sec 7.9.26.4.2 "Link IDE Stream Status Register defines"
> the link state as:
> 
> 0000b Insecure
> 0010b Secure
> 
> The same definition applies to selective streams as well.
> The existing code wrongly assumes "secure" is 0001b, fix that for both
> link and selective streams.
> 
> Fixes: 42fc4263ec0e ("ls-ecaps: Add decode support for IDE Extended Capability")
> Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
> ---
>   ls-ecaps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ls-ecaps.c b/ls-ecaps.c
> index b40ba72..5c2724e 100644
> --- a/ls-ecaps.c
> +++ b/ls-ecaps.c
> @@ -1512,7 +1512,7 @@ static void
>   cap_ide(struct device *d, int where)
>   {
>       const char *hdr_enc_mode[] = { "no", "17:2", "25:2", "33:2", "41:2" };
> -    const char *stream_state[] = { "insecure", "secure" };
> +    const char *stream_state[] = { "insecure", "reserved", "secure" };
>       const char *aggr[] = { "-", "=2", "=4", "=8" };
>       u32 l, l2, linknum = 0, selnum = 0, addrnum, off, i, j;
>       char buf1[16], buf2[16], offs[16];

-- 
Alexey