* [PATCH v1] Documentation: PCI: Update header defining struct pci_device_id
@ 2026-07-06 10:21 Uwe Kleine-König (The Capable Hub)
2026-07-06 10:28 ` sashiko-bot
2026-07-06 10:41 ` Uwe Kleine-König (The Capable Hub)
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-06 10:21 UTC (permalink / raw)
To: Bjorn Helgaas, Jonathan Corbet, Linus Torvalds
Cc: Shuah Khan, linux-pci, linux-doc, linux-kernel
The defintion of struct pci_device_id was moved from
<linux/mod_devicetable.h> to a PCI specific header. Follow the movement
to get the struct's documenation back.
Fixes: ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers")
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,
I'm unsure about the best way to apply it. The obvious options are:
- Linus applies it as he also pulled the header split without involving the
PCI tree; or
- it goes in via the pci tree
- it goes in via the documentation tree
The 2nd is probably preferable if there are pending pci fixes for 7.2
anyhow?!
Best regards
UWe
Documentation/PCI/pci.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
index be35e9a1ee75..71c42b0bfa8b 100644
--- a/Documentation/PCI/pci.rst
+++ b/Documentation/PCI/pci.rst
@@ -84,7 +84,7 @@ initialization with a pointer to a structure describing the driver
The ID table is an array of ``struct pci_device_id`` entries ending with an
all-zero entry. Definitions with static const are generally preferred.
-.. kernel-doc:: include/linux/mod_devicetable.h
+.. kernel-doc:: include/linux/device-id/pci.h
:functions: pci_device_id
Most drivers only need ``PCI_DEVICE()`` or ``PCI_DEVICE_CLASS()`` to set up
base-commit: 8cdeaa50eae8dad34885515f62559ee83e7e8dda
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Documentation: PCI: Update header defining struct pci_device_id
2026-07-06 10:21 [PATCH v1] Documentation: PCI: Update header defining struct pci_device_id Uwe Kleine-König (The Capable Hub)
@ 2026-07-06 10:28 ` sashiko-bot
2026-07-06 10:41 ` Uwe Kleine-König (The Capable Hub)
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-06 10:28 UTC (permalink / raw)
Cc: linux-pci
> The defintion of struct pci_device_id was moved from
> <linux/mod_devicetable.h> to a PCI specific header. Follow the movement
> to get the struct's documenation back.
>
> Fixes: ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers")
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/a01d1cca33187c8b2715227d3db7146465513ced.1783332821.git.u.kleine-koenig@baylibre.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Documentation: PCI: Update header defining struct pci_device_id
2026-07-06 10:21 [PATCH v1] Documentation: PCI: Update header defining struct pci_device_id Uwe Kleine-König (The Capable Hub)
2026-07-06 10:28 ` sashiko-bot
@ 2026-07-06 10:41 ` Uwe Kleine-König (The Capable Hub)
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-06 10:41 UTC (permalink / raw)
To: Bjorn Helgaas, Jonathan Corbet, Linus Torvalds
Cc: Shuah Khan, linux-pci, linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Mon, Jul 06, 2026 at 12:21:15PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The defintion of struct pci_device_id was moved from
> <linux/mod_devicetable.h> to a PCI specific header. Follow the movement
> to get the struct's documenation back.
>
> Fixes: ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers")
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> I'm unsure about the best way to apply it. The obvious options are:
>
> - Linus applies it as he also pulled the header split without involving the
> PCI tree; or
> - it goes in via the pci tree
> - it goes in via the documentation tree
>
> The 2nd is probably preferable if there are pending pci fixes for 7.2
> anyhow?!
There are a few more instances that need a similar fix. So please
disregard this patch, I'll post a complete patch adapting all the now
broken references and target for the first or third option then.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-06 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-06 10:21 [PATCH v1] Documentation: PCI: Update header defining struct pci_device_id Uwe Kleine-König (The Capable Hub)
2026-07-06 10:28 ` sashiko-bot
2026-07-06 10:41 ` Uwe Kleine-König (The Capable Hub)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox