Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] misc: pci_endpoint_test: Add WARN_ON() to detect broken EPC drivers
Date: Thu, 30 Jul 2026 14:02:11 +0200	[thread overview]
Message-ID: <ams9Q-34x6pjbARk@ryzen> (raw)
In-Reply-To: <20260729203850.689781F000E9@smtp.kernel.org>

On Wed, Jul 29, 2026 at 08:38:49PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
> 
> New issues:
> - [High] The newly added `WARN_ON` can be trivially triggered by shared interrupts or untrusted hardware, leading to a Denial of Service (host panic) if `panic_on_warn` is enabled.

Don't think this something we should care about.
This is a test driver, and if someone plugs in a PCIe endpoint on the PCIe bus
that runs the PCIe endpoint framework, and the pci-epf-test driver, they
obviously know what they are doing, and want good/important warnings.

> - [Medium] Direct, lockless read of the internal `done` field in `struct completion` causes a data race, violates API encapsulation, and relies on a flawed TOCTOU heuristic.

Will user proper API in V2.


Kind regards,
Niklas

  reply	other threads:[~2026-07-30 12:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 20:28 [PATCH] misc: pci_endpoint_test: Add WARN_ON() to detect broken EPC drivers Niklas Cassel
2026-07-29 20:38 ` sashiko-bot
2026-07-30 12:02   ` Niklas Cassel [this message]
2026-07-30 12:15     ` Niklas Cassel
2026-07-29 20:49 ` DWC eDMA weirdness Niklas Cassel
2026-07-30  4:32   ` Manivannan Sadhasivam
2026-07-30 10:01     ` Niklas Cassel
2026-07-30  8:39   ` Koichiro Den
2026-07-30 10:43     ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ams9Q-34x6pjbARk@ryzen \
    --to=cassel@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox