From: Niklas Cassel <cassel@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] misc: pci_endpoint_test: Add WARN_ON() to detect broken EPC drivers
Date: Thu, 30 Jul 2026 14:15:40 +0200 [thread overview]
Message-ID: <amtAbPGO5nYA1_VE@ryzen> (raw)
In-Reply-To: <ams9Q-34x6pjbARk@ryzen>
On Thu, Jul 30, 2026 at 02:02:11PM +0200, Niklas Cassel wrote:
> On Wed, Jul 29, 2026 at 08:38:49PM +0000, sashiko-bot@kernel.org wrote:
> > - [Medium] Direct, lockless read of the internal `done` field in `struct completion` causes a data race, violates API encapsulation, and relies on a flawed TOCTOU heuristic.
>
> Will user proper API in V2.
Seems like the proper API is to use completion_done().
But we cannot use this API, as it tries to take the
completion spin lock... so it does not work.
Will just drop this patch for now.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-07-30 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 20:28 [PATCH] misc: pci_endpoint_test: Add WARN_ON() to detect broken EPC drivers Niklas Cassel
2026-07-29 20:38 ` sashiko-bot
2026-07-30 12:02 ` Niklas Cassel
2026-07-30 12:15 ` Niklas Cassel [this message]
2026-07-29 20:49 ` DWC eDMA weirdness Niklas Cassel
2026-07-30 4:32 ` Manivannan Sadhasivam
2026-07-30 10:01 ` Niklas Cassel
2026-07-30 8:39 ` Koichiro Den
2026-07-30 10:43 ` Niklas Cassel
2026-07-30 15:17 ` Koichiro Den
2026-07-30 15:31 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amtAbPGO5nYA1_VE@ryzen \
--to=cassel@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox