Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Oliver OHalloran <oohall@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	Alex Deucher <alexdeucher@gmail.com>,
	Christian Koenig <christian.koenig@amd.com>,
	Vitaly Prosyak <vitaly.prosyak@amd.com>,
	amd-gfx@lists.freedesktop.org,
	Aditya Garg <aditya.garg@linux.dev>,
	Jason Perlow <jperlow@gmail.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH for-linus] PCI/AER: Skip error recovery on false alarms
Date: Mon, 12 Oct 2026 21:17:49 +0200	[thread overview]
Message-ID: <as0yXccnanni6KZe@wunner.de> (raw)
In-Reply-To: <20261009150724.GA974326@bhelgaas>

On Fri, Oct 09, 2026 at 10:07:24AM -0500, Bjorn Helgaas wrote:
> On Fri, Oct 09, 2026 at 06:57:42AM +0200, Lukas Wunner wrote:
> > Apple products with a T2 Secure Enclave will require a separate patch
> > which avoids enabling Advisory Non-Fatal Errors on this particular device.
> > A quirk, in other words.
> > 
> > I think the firmware on the T2 is upgradable in principle, but Apple isn't
> > going to do us the favor to fix it.  So we don't have any other option
> > than keeping a blacklist for ANFE-incompatible devices, with the T2 being
> > the first device on that blacklist and maybe others to follow.
> 
> OK, it sounds like two separate issues needing two separate patches to
> fix.  So I think I'll ask Linus to pull this fix today and watch for
> the quirk next week.

In case it's not obvious, the quirk necessary for the Apple T2
was submitted by Aditya here:

https://lore.kernel.org/r/20261010172301.12764-1-aditya.garg@linux.dev/

Also, Jason attached a functionally identical patch to this e-mail:

https://lore.kernel.org/r/CABZrw2H+3yt2Y7xiq6OyAWaJM7P9ox-2nJxoQuJMwoJHLgi+YQ@mail.gmail.com/

Either patch is a viable fix for this problem.

Thanks,

Lukas

  reply	other threads:[~2026-10-12 19:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 12:26 [PATCH for-linus] PCI/AER: Skip error recovery on false alarms Lukas Wunner
2026-10-08 12:41 ` sashiko-bot
2026-10-08 15:19 ` Alex Deucher
2026-10-08 17:09   ` Lukas Wunner
2026-10-08 19:17 ` Bjorn Helgaas
2026-10-08 19:23   ` Alex Deucher
2026-10-08 19:33     ` Bjorn Helgaas
2026-10-08 19:51       ` Perlow, Jason
2026-10-08 22:02         ` Perlow, Jason
2026-10-09  4:57   ` Lukas Wunner
2026-10-09 15:07     ` Bjorn Helgaas
2026-10-12 19:17       ` Lukas Wunner [this message]
2026-10-09 19:20     ` Aditya Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as0yXccnanni6KZe@wunner.de \
    --to=lukas@wunner.de \
    --cc=aditya.garg@linux.dev \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=helgaas@kernel.org \
    --cc=jperlow@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    --cc=oohall@gmail.com \
    --cc=regressions@leemhuis.info \
    --cc=vitaly.prosyak@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox