From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org,
bhelgaas@google.com
Cc: robh@kernel.org, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH] PCI: qcom: Clear ASPM L0s CAP for MSM8996 SoC
Date: Thu, 27 Nov 2025 11:55:15 +0100 [thread overview]
Message-ID: <bcc61dc3-80ab-4ac4-b9a5-7fc42cff9ab5@oss.qualcomm.com> (raw)
In-Reply-To: <20251126081718.8239-1-mani@kernel.org>
On 11/26/25 9:17 AM, Manivannan Sadhasivam wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> Though I couldn't confirm the ASPM L0s support with the Qcom hardware team,
> bug report from Dmitry suggests that L0s is broken on this legacy SoC.
> Hence, clear the L0s CAP for the Root Ports in this SoC.
FWIW if we trust the downstream DT, we have this hunk:
arch/arm64/boot/dts/qcom/msm8996.dtsi
1431: qcom,l1-supported;
1432: qcom,l1ss-supported;
1586: qcom,l1-supported;
1587: qcom,l1ss-supported;
1739: qcom,l1-supported;
1740: qcom,l1ss-supported;
But also funnily enough, msm8996auto boards specifically manually
do a /delete-property/ on those..
(there exists one 'qcom,l0s-supported', but it's NOT set for 8996, 98,
or 845)
On msm-4.14, this became "qcom,no-l0s/l1/l1ss-supported". This forbids L0s
on at least 8150 and 8250.
Later, both hosts on SM8350 and SM8450-PCIe0 (not 1) forbid L0s.
SM8350-PCIe0 sets 'qcom,l1ss-sleep-disable' which influences some RPMh
things, but also prevents some clock ops wrt the CLKREF source
There's probably more platforms affected, this was a quick grep.
Konrad
next prev parent reply other threads:[~2025-11-27 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 8:17 [PATCH] PCI: qcom: Clear ASPM L0s CAP for MSM8996 SoC Manivannan Sadhasivam
2025-11-26 8:47 ` Dmitry Baryshkov
2025-11-27 10:55 ` Konrad Dybcio [this message]
2025-11-27 13:55 ` Manivannan Sadhasivam
2025-11-27 14:12 ` Konrad Dybcio
2025-12-23 6:41 ` Manivannan Sadhasivam
2025-12-26 23:39 ` Bjorn Helgaas
2025-12-27 4:28 ` Manivannan Sadhasivam
2025-12-30 17:14 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc61dc3-80ab-4ac4-b9a5-7fc42cff9ab5@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox