Linux PCI subsystem development
 help / color / mirror / Atom feed
* [PATCH v2 0/7] Error reporting for AER-incapable devices
@ 2026-11-18 10:40 Lukas Wunner
  2026-11-18 10:40 ` [PATCH v2 1/7] PCI/DPC: Avoid access to non-existent AER capability Lukas Wunner
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Lukas Wunner @ 2026-11-18 10:40 UTC (permalink / raw)
  To: Bjorn Helgaas, Raag Jadav, linux-pci
  Cc: Sourabh Jain, Oliver OHalloran, linuxppc-dev, Aravind Iddamsetty,
	Srinivasa Adatrao, Sathyanarayanan Kuppuswamy, Terry Bowman,
	Keith Busch, Maciej Grochowski, Yazen Ghannam, Darshit Shah,
	Jason Perlow, Riana Tauro, Yury Murashka, Matthew W Carlis

Bjorn suggests "the PCI core should do pci_enable_pcie_error_reporting()
independent of whether the device has an AER Capability":

https://lore.kernel.org/r/20260826212619.GA1566339@bhelgaas/

This is done in patch [7/7].  The preceding patches contain prep work.

For context, PCIe r7.1 sec 6.2.1 defines two error reporting paradigms:
AER and baseline capability.  The latter relies (solely) on the error
enable/status bits in the Device Control and Device Status registers,
which exist on every PCIe device.  The kernel has supported the AER
paradigm for 20 years.  With the present series, it gains support for
the baseline capability paradigm.

Patches [1/7] and [2/7] reinstate DPC on AER-incapable Downstream Ports.
The kernel used to support this until 2018.  It is hereby fixed because
it eases introduction of baseline capability error reporting in the
subsequent patches.


Changes v1 -> v2:

* Patch [1/7]:
  * On AER-capable devices, infer severity from AER Extended Capability
    instead of Device Status register because the latter also logs masked
    errors (Sathya).
  * Fix storytelling in commit message because 4e5fad429bd1 changed
    behavior, not 708b20003624 (Sathya).

* Patch [3/7]:
  * New patch to clear error status bits more selectively (sashiko).

* Patch [4/7]:
  * Clear Fatal Errors as well on recovery failure (Sathya, sashiko).

* Patch [6/7]:
  * Amend kernel-doc of pci_aer_unmask_internal_errors() (Sathya).

* Patch [7/7]:
  * Convert AER severity to Device Status bit with new severity2devsta[]
    array, instead of renumbering AER severity (sashiko).
  * On entry of aer_get_device_error_info(), clear info->mask and
    info->first_error (Sathya, sashiko).
  * Emit "(no details available)" message for AER-incapable devices
    as well as for devices whose AER registers are deliberately not
    read on Fatal Errors (Sathya).
  * Amend commit message to inform that System Errors may be raised
    by AER-incapable devices if they have no AER- or DPC-capable
    port in their ancestry (Sathya).

Link to v1:

https://lore.kernel.org/r/cover.1790531238.git.lukas@wunner.de/


Lukas Wunner (6):
  PCI/DPC: Avoid access to non-existent AER capability
  PCI/DPC: Reinstate support for AER-incapable ports
  PCI/ERR: Clear error status bits more selectively
  PCI/AER: Drop AER native check from handles_cxl_errors()
  PCI/AER: Move AER capability check out of pcie_aer_is_native()
  PCI/AER: Enable baseline capability error reporting

Yury Murashka (1):
  PCI/ERR: Avoid stale error status bits on recovery failure

 .../ABI/testing/sysfs-bus-pci-devices-aer     | 26 +++++--
 Documentation/PCI/pcieaer-howto.rst           |  9 +--
 drivers/pci/pcie/aer.c                        | 76 +++++++++++++------
 drivers/pci/pcie/aer_cxl_rch.c                |  3 +-
 drivers/pci/pcie/dpc.c                        | 46 +++++++----
 drivers/pci/pcie/err.c                        | 14 +++-
 6 files changed, 120 insertions(+), 54 deletions(-)


base-commit: 6d69eeae8966bc3bea0facbd550f45ef9de41cc4
-- 
2.53.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-11-18 11:19 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 10:40 [PATCH v2 0/7] Error reporting for AER-incapable devices Lukas Wunner
2026-11-18 10:40 ` [PATCH v2 1/7] PCI/DPC: Avoid access to non-existent AER capability Lukas Wunner
2026-11-18 11:04   ` sashiko-bot
2026-11-18 10:40 ` [PATCH v2 2/7] PCI/DPC: Reinstate support for AER-incapable ports Lukas Wunner
2026-11-18 11:03   ` sashiko-bot
2026-11-18 10:40 ` [PATCH v2 3/7] PCI/ERR: Clear error status bits more selectively Lukas Wunner
2026-11-18 11:09   ` sashiko-bot
2026-11-18 10:40 ` [PATCH v2 4/7] PCI/ERR: Avoid stale error status bits on recovery failure Lukas Wunner
2026-11-18 11:18   ` sashiko-bot
2026-11-18 10:40 ` [PATCH v2 5/7] PCI/AER: Drop AER native check from handles_cxl_errors() Lukas Wunner
2026-11-18 11:02   ` sashiko-bot
2026-11-18 10:40 ` [PATCH v2 6/7] PCI/AER: Move AER capability check out of pcie_aer_is_native() Lukas Wunner
2026-11-18 11:13   ` sashiko-bot
2026-11-18 10:40 ` [PATCH v2 7/7] PCI/AER: Enable baseline capability error reporting Lukas Wunner
2026-11-18 11:19   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox